Re: [HACKERS] SearchSysCache, SysCacheGetAttr, and heap_getattr()

2017-01-19 Thread Tom Lane
Stephen Frost writes: > There's some inconsistency when it comes to if we actually use > SysCacheGetAttr() when pulling an attribute for a tuple we got via > SearchSysCache(), or if we use heap_getattr(). > Maybe I'm missing something, but that seems less than ideal. Well, SysCacheGetAttr just i

[HACKERS] SearchSysCache, SysCacheGetAttr, and heap_getattr()

2017-01-19 Thread Stephen Frost
Greetings, There's some inconsistency when it comes to if we actually use SysCacheGetAttr() when pulling an attribute for a tuple we got via SearchSysCache(), or if we use heap_getattr(). Maybe I'm missing something, but that seems less than ideal. I've generally been under the belief that using