Re: [HACKERS] SET TRANSACTION and SQL Standard

2009-01-21 Thread Bruce Momjian
Heikki Linnakangas wrote: > Simon Riggs wrote: > > On Fri, 2009-01-09 at 16:14 +0200, Peter Eisentraut wrote: > >> Simon Riggs wrote: > >>> I notice that we allow commands such as > >>> > >>> SET TRANSACTION read only read write read only; > >>> > >>> BEGIN TRANSACTION read only read only read only

Re: [HACKERS] SET TRANSACTION and SQL Standard

2009-01-12 Thread Tom Lane
Peter Eisentraut writes: > I think this might be best solved by providing a common function that > checks a DefElem list for duplicates. This could be used in a number of > other places as well (grep for "conflicting or redundant options"). It's not clear what that would save exactly. The com

Re: [HACKERS] SET TRANSACTION and SQL Standard

2009-01-12 Thread Peter Eisentraut
Tom Lane wrote: Peter Eisentraut writes: Simon Riggs wrote: I notice that we allow commands such as SET TRANSACTION read only read write read only; BEGIN TRANSACTION read only read only read only; My own feeling is that the second example is okay but the first should be rejected, since (a)

Re: [HACKERS] SET TRANSACTION and SQL Standard

2009-01-09 Thread Simon Riggs
On Fri, 2009-01-09 at 11:20 -0500, Tom Lane wrote: > Simon Riggs writes: > > "If any condition required by Syntax Rules is not satisfied when the > > evaluation of Access or General Rules is attempted and the > > implementation is neither processing non-conforming SQL language nor > > processing

Re: [HACKERS] SET TRANSACTION and SQL Standard

2009-01-09 Thread Tom Lane
Simon Riggs writes: > "If any condition required by Syntax Rules is not satisfied when the > evaluation of Access or General Rules is attempted and the > implementation is neither processing non-conforming SQL language nor > processing conforming SQL language in a non-conforming manner, then an >

Re: [HACKERS] SET TRANSACTION and SQL Standard

2009-01-09 Thread Simon Riggs
On Fri, 2009-01-09 at 17:11 +0200, Heikki Linnakangas wrote: > Simon Riggs wrote: > > On Fri, 2009-01-09 at 16:14 +0200, Peter Eisentraut wrote: > >> Simon Riggs wrote: > >>> I notice that we allow commands such as > >>> > >>> SET TRANSACTION read only read write read only; > >>> > >>> BEGIN TRANS

Re: [HACKERS] SET TRANSACTION and SQL Standard

2009-01-09 Thread Heikki Linnakangas
Simon Riggs wrote: On Fri, 2009-01-09 at 16:14 +0200, Peter Eisentraut wrote: Simon Riggs wrote: I notice that we allow commands such as SET TRANSACTION read only read write read only; BEGIN TRANSACTION read only read only read only; Unsurprisingly, these violate the SQL Standard: * p.977 se

Re: [HACKERS] SET TRANSACTION and SQL Standard

2009-01-09 Thread Simon Riggs
On Fri, 2009-01-09 at 16:14 +0200, Peter Eisentraut wrote: > Simon Riggs wrote: > > I notice that we allow commands such as > > > > SET TRANSACTION read only read write read only; > > > > BEGIN TRANSACTION read only read only read only; > > > > Unsurprisingly, these violate the SQL Standard: >

Re: [HACKERS] SET TRANSACTION and SQL Standard

2009-01-09 Thread Tom Lane
Peter Eisentraut writes: > Simon Riggs wrote: >> I notice that we allow commands such as >> SET TRANSACTION read only read write read only; >> BEGIN TRANSACTION read only read only read only; > Well, we allow a lot of things. Violations of the SQL standard happen > when a command that appears i

Re: [HACKERS] SET TRANSACTION and SQL Standard

2009-01-09 Thread Peter Eisentraut
Simon Riggs wrote: I notice that we allow commands such as SET TRANSACTION read only read write read only; BEGIN TRANSACTION read only read only read only; Unsurprisingly, these violate the SQL Standard: * p.977 section 19.1 syntax (1) * p.957 section 17.3 syntax (2) Well, we allow a lot of

[HACKERS] SET TRANSACTION and SQL Standard

2008-12-31 Thread Simon Riggs
I notice that we allow commands such as SET TRANSACTION read only read write read only; BEGIN TRANSACTION read only read only read only; Unsurprisingly, these violate the SQL Standard: * p.977 section 19.1 syntax (1) * p.957 section 17.3 syntax (2) Not planning on fixing it myself, but others m