Re: [HACKERS] SAVEPOINTs and COMMIT performance

2011-07-14 Thread Simon Riggs
On Mon, Jun 6, 2011 at 10:33 AM, Heikki Linnakangas wrote: > On 06.02.2011 23:09, Simon Riggs wrote: >> >> On Sun, 2011-02-06 at 12:11 -0500, Bruce Momjian wrote: >>> >>> Did this ever get addressed? >> >> Patch attached. >> >> Seems like the easiest fix I can come up with. > >> @@ -2518,7 +2518,7

Re: [HACKERS] SAVEPOINTs and COMMIT performance

2011-06-06 Thread Simon Riggs
On Mon, Jun 6, 2011 at 10:33 AM, Heikki Linnakangas wrote: > On 06.02.2011 23:09, Simon Riggs wrote: >> >> On Sun, 2011-02-06 at 12:11 -0500, Bruce Momjian wrote: >>> >>> Did this ever get addressed? >> >> Patch attached. >> >> Seems like the easiest fix I can come up with. > >> @@ -2518,7 +2518,7

Re: [HACKERS] SAVEPOINTs and COMMIT performance

2011-06-06 Thread Heikki Linnakangas
On 06.02.2011 23:09, Simon Riggs wrote: On Sun, 2011-02-06 at 12:11 -0500, Bruce Momjian wrote: Did this ever get addressed? Patch attached. Seems like the easiest fix I can come up with. @@ -2518,7 +2518,7 @@ CommitTransactionCommand(void) case TBLOCK_SUBEND:

Re: [HACKERS] SAVEPOINTs and COMMIT performance

2011-03-11 Thread Robert Haas
On Fri, Mar 11, 2011 at 7:18 AM, Bruce Momjian wrote: > What happened to this patch? I added it to the next CommitFest. It would be reasonably to apply it sooner, perhaps, but nobody's reviewed it. Want to volunteer? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Post

Re: [HACKERS] SAVEPOINTs and COMMIT performance

2011-03-11 Thread Bruce Momjian
What happened to this patch? --- Simon Riggs wrote: > On Sun, 2011-02-06 at 12:11 -0500, Bruce Momjian wrote: > > Did this ever get addressed? > > Patch attached. > > Seems like the easiest fix I can come up with. > > > S

Re: [HACKERS] SAVEPOINTs and COMMIT performance

2011-02-06 Thread Simon Riggs
On Sun, 2011-02-06 at 12:11 -0500, Bruce Momjian wrote: > Did this ever get addressed? Patch attached. Seems like the easiest fix I can come up with. > Simon Riggs wrote: > > > > As part of a performance investigation for a customer I've noticed an > > O(N^2) performance issue on COMMITs of tra

Re: [HACKERS] SAVEPOINTs and COMMIT performance

2011-02-06 Thread Bruce Momjian
Did this ever get addressed? --- Simon Riggs wrote: > > As part of a performance investigation for a customer I've noticed an > O(N^2) performance issue on COMMITs of transactions that contain many > SAVEPOINTs. I've consis

[HACKERS] SAVEPOINTs and COMMIT performance

2010-07-20 Thread Simon Riggs
As part of a performance investigation for a customer I've noticed an O(N^2) performance issue on COMMITs of transactions that contain many SAVEPOINTs. I've consistently measured COMMIT times of around 9 seconds, with 49% CPU, mostly in LockReassignCurrentOwner(). BEGIN; INSERT... SAVEPOINT ... I