Re: [HACKERS] Ripping out pg_restore's attempts to parse SQL before sending it

2011-07-27 Thread Tom Lane
I wrote: > While I've not yet done any excavation in the commit logs to confirm > this, the nearby comments in the code indicate that separation of COPY > data from SQL commands was adopted in archive format version 1.3, which > is ancient. In fact, it's so ancient that there was never a productio

[HACKERS] Ripping out pg_restore's attempts to parse SQL before sending it

2011-07-27 Thread Tom Lane
In http://archives.postgresql.org/message-id/201107270042.22427.jul...@mehnle.net it's pointed out that pg_restore in direct-to-database mode is pretty badly broken if standard_conforming_strings=on. The reason is that it tries to lex SQL commands well enough to find line boundaries, and the code