Re: [HACKERS] Revised patches to add table function support to PL/Tcl (TODO item)

2011-02-10 Thread Andrew Dunstan
On 02/08/2011 08:37 PM, Andrew Dunstan wrote: On 02/07/2011 11:30 PM, Robert Haas wrote: On Tue, Dec 28, 2010 at 9:23 PM, Karl Lehenbauer wrote: On Dec 28, 2010, at 7:29 PM, Tom Lane wrote: This patch appears to be changing a whole lot of stuff that in fact pg_indent has never changed, s

Re: [HACKERS] Revised patches to add table function support to PL/Tcl (TODO item)

2011-02-08 Thread Andrew Dunstan
On 02/07/2011 11:30 PM, Robert Haas wrote: On Tue, Dec 28, 2010 at 9:23 PM, Karl Lehenbauer wrote: On Dec 28, 2010, at 7:29 PM, Tom Lane wrote: This patch appears to be changing a whole lot of stuff that in fact pg_indent has never changed, so there's something wrong with the way you are do

Re: [HACKERS] Revised patches to add table function support to PL/Tcl (TODO item)

2011-02-07 Thread Robert Haas
On Tue, Dec 28, 2010 at 9:23 PM, Karl Lehenbauer wrote: > On Dec 28, 2010, at 7:29 PM, Tom Lane wrote: >> This patch appears to be changing a whole lot of stuff that in fact >> pg_indent has never changed, so there's something wrong with the way you >> are doing it.  It looks like a bad typedef li

Re: [HACKERS] Revised patches to add table function support to PL/Tcl (TODO item)

2010-12-28 Thread Tom Lane
Karl Lehenbauer writes: > The first patch, pltcl-karl-try2-1-of-3-pgindent.patch, does nothing but > conform HEAD's pltcl.c with pgindent. Applying this patch should have > exactly the same effect as running > src/tools/pgindent/pgindent src/tools/pgindent/typedefs.list > src/pl/tcl/pl