Re: [HACKERS] Review of patch Bugfix for XPATH() if expression returns a scalar value

2011-07-14 Thread Florian Pflug
Hi Radosław, Do you plan to comment on this patch (the one that adds support for XPATH expressions returning scalar values, not the one that escapes text and attributes nodes which are selected) further, or should it be marked "Ready for Committer"? I'm asking because I just noticed that you mark

Re: [HACKERS] Review of patch Bugfix for XPATH() if expression returns a scalar value

2011-07-04 Thread Florian Pflug
Hi Radosław, Do you still have objections, or did I manage to convince you? Also, aside from the question of whether to escape or not, did you find any issues with either the patch (like spurious whitespace, ...) or the code, or is the patch OK implementation-wise? best regards, Florian Pflug

Re: [HACKERS] Review of patch Bugfix for XPATH() if expression returns a scalar value

2011-06-30 Thread Florian Pflug
On Jun30, 2011, at 10:33 , Radosław Smogura wrote: > You may manually enter invalid xml too, You don't need xpath for this. Please give an example, instead of merely asserting I get postgres=# select '<'::xml; ERROR: invalid XML content at character 8 > Much more > In PostgreSQL 9.0.1, compiled

Re: [HACKERS] Review of patch Bugfix for XPATH() if expression returns a scalar value

2011-06-29 Thread Florian Pflug
On Jun29, 2011, at 19:57 , Radosław Smogura wrote: > This is review of patch > https://commitfest.postgresql.org/action/patch_view?id=565 > "Bugfix for XPATH() if expression returns a scalar value" > > SELECT XMLELEMENT(name root, XMLATTRIBUTES(foo.namespace AS sth)) FROM > (SELECT > (XPATH('nam

[HACKERS] Review of patch Bugfix for XPATH() if expression returns a scalar value

2011-06-29 Thread Radosław Smogura
This is review of patch https://commitfest.postgresql.org/action/patch_view?id=565 "Bugfix for XPATH() if expression returns a scalar value" Patch applies cleanly, and compiles cleanly too, I didn't checked tests. Form discussion about patch, and referenced thread in this patch http://ar