Re: [HACKERS] Review for EXPLAIN and nfiltered

2011-09-19 Thread Robert Haas
On Mon, Sep 19, 2011 at 3:10 PM, Marc Cousin wrote: > 2011/9/19 Robert Haas : >> On Mon, Sep 19, 2011 at 12:51 PM, Marc Cousin wrote: >>> Here is my review for EXPLAIN and nfiltered >>> (http://archives.postgresql.org/message-id/4e6e9e83.7070...@2ndquadrant.com) >> >> Please add this review to th

Re: [HACKERS] Review for EXPLAIN and nfiltered

2011-09-19 Thread Marc Cousin
2011/9/19 Robert Haas : > On Mon, Sep 19, 2011 at 12:51 PM, Marc Cousin wrote: >> Here is my review for EXPLAIN and nfiltered >> (http://archives.postgresql.org/message-id/4e6e9e83.7070...@2ndquadrant.com) > > Please add this review to the CommitFest app here: > > https://commitfest.postgresql.org

Re: [HACKERS] Review for EXPLAIN and nfiltered

2011-09-19 Thread Robert Haas
On Mon, Sep 19, 2011 at 12:51 PM, Marc Cousin wrote: > Here is my review for EXPLAIN and nfiltered > (http://archives.postgresql.org/message-id/4e6e9e83.7070...@2ndquadrant.com) Please add this review to the CommitFest app here: https://commitfest.postgresql.org/action/patch_view?id=638 ...and

[HACKERS] Review for EXPLAIN and nfiltered

2011-09-19 Thread Marc Cousin
Here is my review for EXPLAIN and nfiltered (http://archives.postgresql.org/message-id/4e6e9e83.7070...@2ndquadrant.com) - Is the patch in context diff format? It's in git diff format - Does it apply cleanly to the current git master? Yes - Does it include reasonable tests, necessary doc patches