Re: [HACKERS] Review: create extension default_full_version

2013-02-22 Thread Dimitri Fontaine
Ibrar Ahmed writes: > * In case we have hstore--1.3.sql file and want to install that file, but > failed because of default_full_version. That's now fixed, please see the Extension Templates patch at http://www.postgresql.org/message-id/m21uc8l4j8@2ndquadrant.fr Where you will even find r

Re: [HACKERS] Review: create extension default_full_version

2012-12-11 Thread Ibrar Ahmed
Now it works in most of the cases, here is one more point about the patch. * In case we have hstore--1.3.sql file and want to install that file, but failed because of default_full_version. No default_full_version specified --- postgres=# CREATE EXTENSIO

Re: [HACKERS] Review: create extension default_full_version

2012-12-04 Thread Ibrar Ahmed
On Tue, Dec 4, 2012 at 7:54 PM, Dimitri Fontaine wrote: > Ibrar Ahmed writes: > > I am still getting the same error message. > > With the attached patch (v2), it works well: > > create extension hstore version '1.2' from 'unpackaged'; > DEBUG: execute_extension_script: > '/Users/dim/pgsql/ddl/sh

Re: [HACKERS] Review: create extension default_full_version

2012-12-04 Thread Dimitri Fontaine
Ibrar Ahmed writes: > I am still getting the same error message. With the attached patch (v2), it works well: create extension hstore version '1.2' from 'unpackaged'; DEBUG: execute_extension_script: '/Users/dim/pgsql/ddl/share/extension/hstore--unpackaged--1.0.sql' DEBUG: execute_extension_s

Re: [HACKERS] Review: create extension default_full_version

2012-12-04 Thread Ibrar Ahmed
On Mon, Dec 3, 2012 at 11:05 PM, Dimitri Fontaine wrote: > Hi, > > Thanks for your very good review! > > Ibrar Ahmed writes: > > I looked at the discussion for this patch and the patch itself. Here > > are my comments and observations about the patch. > > What I got from the discussion is that th

Re: [HACKERS] Review: create extension default_full_version

2012-12-03 Thread Dimitri Fontaine
Hi, Thanks for your very good review! Ibrar Ahmed writes: > I looked at the discussion for this patch and the patch itself. Here > are my comments and observations about the patch. > What I got from the discussion is that the patch tries to implement a > mechanism to install extension from serie

[HACKERS] Review: create extension default_full_version

2012-11-30 Thread Ibrar Ahmed
Hi, I looked at the discussion for this patch and the patch itself. Here are my comments and observations about the patch. What I got from the discussion is that the patch tries to implement a mechanism to install extension from series of SQL scripts from base/full version e.g. if a user wants to