On 08/29/2014 10:15 AM, Noah Misch wrote:
On Thu, Aug 21, 2014 at 11:29:31PM -0400, Noah Misch wrote:
On Thu, Aug 21, 2014 at 09:18:22AM -0400, Andrew Dunstan wrote:
What's happening about this? Buildfarm animal jacana is consistently
red because of this.
If nobody plans to do the aforementio
On Thu, Aug 21, 2014 at 11:29:31PM -0400, Noah Misch wrote:
> On Thu, Aug 21, 2014 at 09:18:22AM -0400, Andrew Dunstan wrote:
> > What's happening about this? Buildfarm animal jacana is consistently
> > red because of this.
>
> If nobody plans to do the aforementioned analysis in the next 4-7 days
On Fri, Aug 22, 2014 at 04:58:47PM +0900, Michael Paquier wrote:
> Looking more into that, I am seeing that MinGW-32 is failing to find socket
> at configure, contrary to MinGW-64.
>
> Here is what happens for MinGW-64 at configure:
> configure:7638: checking for library containing socket
> [...]
On Fri, Aug 15, 2014 at 8:00 PM, Noah Misch wrote:
>
> On Fri, Aug 15, 2014 at 12:49:36AM -0700, Michael Paquier wrote:
> > Btw, how do you determine if MSVC is using HAVE_GETADDRINFO? Is it
> > decided by the inclusion of getaddrinfo.c in @pgportfiles of
> > Mkvdbuild.pm?
>
> src/include/pg_confi
On Thu, Aug 21, 2014 at 09:18:22AM -0400, Andrew Dunstan wrote:
>
> On 08/15/2014 11:00 PM, Noah Misch wrote:
> >On Fri, Aug 15, 2014 at 12:49:36AM -0700, Michael Paquier wrote:
> >>Btw, how do you determine if MSVC is using HAVE_GETADDRINFO? Is it
> >>decided by the inclusion of getaddrinfo.c in
On 08/15/2014 11:00 PM, Noah Misch wrote:
On Fri, Aug 15, 2014 at 12:49:36AM -0700, Michael Paquier wrote:
Btw, how do you determine if MSVC is using HAVE_GETADDRINFO? Is it
decided by the inclusion of getaddrinfo.c in @pgportfiles of
Mkvdbuild.pm?
src/include/pg_config.h.win32 dictates it, an
On Fri, Aug 15, 2014 at 12:49:36AM -0700, Michael Paquier wrote:
> Btw, how do you determine if MSVC is using HAVE_GETADDRINFO? Is it
> decided by the inclusion of getaddrinfo.c in @pgportfiles of
> Mkvdbuild.pm?
src/include/pg_config.h.win32 dictates it, and we must keep @pgportfiles
synchronized
On Mon, Aug 11, 2014 at 10:48 PM, Noah Misch wrote:
> Consistency with the MSVC build is desirable, either HAVE_GETADDRINFO for both
> or !HAVE_GETADDRINFO for both.
Hm. Looking here getattrinfo has been added in ws2_32 and was not
present in wsock32:
http://msdn.microsoft.com/en-us/library/windo
On Tue, Aug 12, 2014 at 01:58:17PM +0900, Michael Paquier wrote:
> On Tue, Aug 12, 2014 at 9:43 AM, Noah Misch wrote:
> >
> > Somehow or other, we must bring these parts into agreement.
>
>
> It is interesting to see that with MinGW-32b getaddrinfo is still set
> to no at configure phase. What i
On Tue, Aug 12, 2014 at 9:43 AM, Noah Misch wrote:
>
> Somehow or other, we must bring these parts into agreement.
It is interesting to see that with MinGW-32b getaddrinfo is still set
to no at configure phase. What if we simply wrap "undef gai_strerror"
like in the patch attached? I just set up
On Mon, Aug 11, 2014 at 11:02:48AM -0700, Jeff Janes wrote:
> While trying to test more recent stuff against mingw, I kept running into a
> problem which bisected down to this (a16bac36eca8158cbf78987e953).
> This is the warning/error I get:
>
> auth.c: In function 'ClientAuthentication':
> auth.
On Tue, Jul 15, 2014 at 5:14 AM, Michael Paquier
wrote:
> On Tue, Jul 15, 2014 at 8:46 PM, Magnus Hagander
> wrote:
> > On Thu, Jun 19, 2014 at 4:13 PM, MauMau wrote:
> >> From: "Michael Paquier"
> >>
> >>> You are right, I only though about the MS scripts when working on this
> >>> patch. Upd
On Tue, Jul 15, 2014 at 9:20 PM, Magnus Hagander wrote:
> On Tue, Jul 15, 2014 at 2:14 PM, Michael Paquier
> wrote:
>> Of course someone else than the patch author with a MinGW environment
>> at hand is invited to test.
>
> Thanks!
>
> I think that's enough - the functionality has already been ve
On Tue, Jul 15, 2014 at 2:14 PM, Michael Paquier
wrote:
> On Tue, Jul 15, 2014 at 8:46 PM, Magnus Hagander wrote:
>> On Thu, Jun 19, 2014 at 4:13 PM, MauMau wrote:
>>> From: "Michael Paquier"
>>>
You are right, I only though about the MS scripts when working on this
patch. Updated pat
On Tue, Jul 15, 2014 at 8:46 PM, Magnus Hagander wrote:
> On Thu, Jun 19, 2014 at 4:13 PM, MauMau wrote:
>> From: "Michael Paquier"
>>
>>> You are right, I only though about the MS scripts when working on this
>>> patch. Updated patch for a complete cleanup is attached (note I
>>> updated manual
On Thu, Jun 19, 2014 at 4:13 PM, MauMau wrote:
> From: "Michael Paquier"
>
>> You are right, I only though about the MS scripts when working on this
>> patch. Updated patch for a complete cleanup is attached (note I
>> updated manually ./configure for test purposes and did not re-run
>> autoconf)
On Thu, Jun 19, 2014 at 11:13 PM, MauMau wrote:
> * The patch applies cleanly. Running "grep -lir wsock32 ." after applying
> the patch shows that wsock32.lib is no longer used.
> However, I wonder if some DLL entries in dlls[] in
> src/interfaces/libpq/win32.c should be removed. winsock.dll sho
From: "Michael Paquier"
You are right, I only though about the MS scripts when working on this
patch. Updated patch for a complete cleanup is attached (note I
updated manually ./configure for test purposes and did not re-run
autoconf).
I marked this patch as ready for committer. I confirmed:
On Wed, Jun 18, 2014 at 8:37 PM, MauMau wrote:
> Doing "grep -lir wsock32 ." shows the following files. Could you modify and
> test these files as well for code cleanup?
> ./configure
> ./configure.in
> ./contrib/pgcrypto/Makefile
> ./src/interfaces/libpq/Makefile
> ./src/interfaces/libpq/win32.c
From: "Michael Paquier"
When doing some work on Windows, I noticed that the mkvc specs in
src/tools/msvc use wsock32.lib, which is as far as I understand an
old, obsolete version of the Windows socket library. Wouldn't it make
sense to update the specs to build only with ws2_32.lib like in the
p
On Mon, Apr 21, 2014 at 12:54 PM, Michael Paquier wrote:
> When doing some work on Windows, I noticed that the mkvc specs in
> src/tools/msvc use wsock32.lib, which is as far as I understand an
> old, obsolete version of the Windows socket library. Wouldn't it make
> sense to update the specs to
Hi all,
When doing some work on Windows, I noticed that the mkvc specs in
src/tools/msvc use wsock32.lib, which is as far as I understand an
old, obsolete version of the Windows socket library. Wouldn't it make
sense to update the specs to build only with ws2_32.lib like in the
patch attached?
Reg
22 matches
Mail list logo