Re: [HACKERS] RemoveSubscriptionRel uses simple_heap_delete

2017-06-14 Thread Masahiko Sawada
On Wed, Jun 14, 2017 at 10:44 PM, Tom Lane wrote: > Masahiko Sawada writes: >> Currently $subject but should we use CatalogTupleDelete() instead? >> It's actually the same behavior though. Other functions use >> CatalogTupleXXX(). Attached patch. > > Yeah, evidently that patch failed to track the

Re: [HACKERS] RemoveSubscriptionRel uses simple_heap_delete

2017-06-14 Thread Tom Lane
Masahiko Sawada writes: > Currently $subject but should we use CatalogTupleDelete() instead? > It's actually the same behavior though. Other functions use > CatalogTupleXXX(). Attached patch. Yeah, evidently that patch failed to track the effects of commits 2f5c9d9c9 et al, since it wasn't in-tre

[HACKERS] RemoveSubscriptionRel uses simple_heap_delete

2017-06-13 Thread Masahiko Sawada
Hi, Currently $subject but should we use CatalogTupleDelete() instead? It's actually the same behavior though. Other functions use CatalogTupleXXX(). Attached patch. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center change_to_use_CatalogTupl