Re: [HACKERS] Remove unused function from walsender.c

2016-04-12 Thread Fujii Masao
On Tue, Apr 12, 2016 at 6:36 AM, Simon Riggs wrote: > On 11 April 2016 at 08:05, Fujii Masao wrote: > >> >> There is an unused function GetOldestWALSendPointer() in walsender.c. >> Per comment, it was introduced because we may need it in the future for >> synchronous replication. >> >> Now we hav

Re: [HACKERS] Remove unused function from walsender.c

2016-04-11 Thread Simon Riggs
On 11 April 2016 at 08:05, Fujii Masao wrote: > There is an unused function GetOldestWALSendPointer() in walsender.c. > Per comment, it was introduced because we may need it in the future for > synchronous replication. > > Now we have very similar function SyncRepGetOldestSyncRecPtr() in > syncr

[HACKERS] Remove unused function from walsender.c

2016-04-11 Thread Fujii Masao
Hi, There is an unused function GetOldestWALSendPointer() in walsender.c. Per comment, it was introduced because we may need it in the future for synchronous replication. Now we have very similar function SyncRepGetOldestSyncRecPtr() in syncrep.c. Which makes me think that GetOldestWALSendPointer