Re: [HACKERS] Regression error on float8

2006-04-24 Thread Magnus Hagander
> > That totally didn't work on visual c++ at least. It fixes those two > > ones, but it breaks the other lines in the same test: > > It's a couple bricks shy of a load (doesn't handle zero or > negative input correctly) but easily fixed. I'm just about > to commit it. Great. I'll check it ou

Re: [HACKERS] Regression error on float8

2006-04-24 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > That totally didn't work on visual c++ at least. It fixes those two > ones, but it breaks the other lines in the same test: It's a couple bricks shy of a load (doesn't handle zero or negative input correctly) but easily fixed. I'm just about to comm

Re: [HACKERS] Regression error on float8

2006-04-24 Thread Magnus Hagander
> > What do you think is best - try to adapt that version, or > update our > > regression tests outputs to accept the output from our current code? > > Given that our output gets very very close, perhaps we should > take a hint from the end of the MinGW version, do a single > Newton iteration

Re: [HACKERS] Regression error on float8

2006-04-24 Thread Tom Lane
Martijn van Oosterhout writes: > Given that our output gets very very close, perhaps we should take a > hint from the end of the MinGW version, do a single Newton iteration to > fixup those last few digits. That seems like a plan to me. regards, tom lane

Re: [HACKERS] Regression error on float8

2006-04-24 Thread Martijn van Oosterhout
On Mon, Apr 24, 2006 at 03:01:51PM +0200, Magnus Hagander wrote: > If I undefine HAVE_CBRT on Linux, I get the exact same failure! So it > seems our own version of cbrt() is broken wrt our own regression tests > :-( Must be that nobody else (at least on i386) uses that code. > What do you think

Re: [HACKERS] Regression error on float8

2006-04-24 Thread Magnus Hagander
> > I'm getting the following regression errors with a backend > built using > > Visual C++: > > Is HAVE_CBRT getting defined? Either their cbrt() routine or > our default one seems to be generating slightly-off answers. > The default one (at the bottom of float.c) certainly looks a > bit c

Re: [HACKERS] Regression error on float8

2006-04-23 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > I'm getting the following regression errors with a backend built using > Visual C++: Is HAVE_CBRT getting defined? Either their cbrt() routine or our default one seems to be generating slightly-off answers. The default one (at the bottom of float.c

[HACKERS] Regression error on float8

2006-04-23 Thread Magnus Hagander
I'm getting the following regression errors with a backend built using Visual C++: *** ./expected/float8-exp-three-digits-win32.outWed Jun 8 23:15:29 2005 --- ./results/float8.outSun Apr 23 20:44:44 2006 *** *** 324,331 |0 |