Re: [HACKERS] Refactor xlog.c #1 - startup.c

2011-11-02 Thread Simon Riggs
On Wed, Nov 2, 2011 at 1:44 PM, Magnus Hagander wrote: > Double prototypes seems to me like it's a cure worse than the disease to me... Doubling them was just a mistake. Anyway, thats gone now. --  Simon Riggs   http://www.2ndQuadrant.com/  PostgreSQL Development, 24x7 Support,

Re: [HACKERS] Refactor xlog.c #1 - startup.c

2011-11-02 Thread Magnus Hagander
On Wed, Nov 2, 2011 at 14:33, Simon Riggs wrote: > On Wed, Nov 2, 2011 at 1:14 PM, Robert Haas wrote: >> On Wed, Nov 2, 2011 at 4:44 AM, Simon Riggs wrote: >>> Patch removes stuff related to "startup process" and creates files >>> under src/$DIR/postmaster for this code. >>> >>> This makes start

Re: [HACKERS] Refactor xlog.c #1 - startup.c

2011-11-02 Thread Simon Riggs
On Wed, Nov 2, 2011 at 1:14 PM, Robert Haas wrote: > On Wed, Nov 2, 2011 at 4:44 AM, Simon Riggs wrote: >> Patch removes stuff related to "startup process" and creates files >> under src/$DIR/postmaster for this code. >> >> This makes startup process look more like bgwriter, walwriter etc.. > > I

Re: [HACKERS] Refactor xlog.c #1 - startup.c

2011-11-02 Thread Robert Haas
On Wed, Nov 2, 2011 at 4:44 AM, Simon Riggs wrote: > Patch removes stuff related to "startup process" and creates files > under src/$DIR/postmaster for this code. > > This makes startup process look more like bgwriter, walwriter etc.. In general, +1. But I don't think we want duplicate function

[HACKERS] Refactor xlog.c #1 - startup.c

2011-11-02 Thread Simon Riggs
Patch removes stuff related to "startup process" and creates files under src/$DIR/postmaster for this code. This makes startup process look more like bgwriter, walwriter etc.. Other refactoring patches to follow, chipping away at xlog.c. --  Simon Riggs   http://www.2ndQuadrant.