Re: [HACKERS] Recovery bug in GIN, missing full page image

2013-12-03 Thread Heikki Linnakangas
On 12/03/2013 04:39 PM, Heikki Linnakangas wrote: While looking at Alexander's GIN patch, I noticed an ancient bug in the WAL-logging of GIN entry-tree insertions. entryPlaceToPage and dataPlacetoPage functions don't make a full-page image of the page, when inserting a downlink on a non-leaf page

[HACKERS] Recovery bug in GIN, missing full page image

2013-12-03 Thread Heikki Linnakangas
While looking at Alexander's GIN patch, I noticed an ancient bug in the WAL-logging of GIN entry-tree insertions. entryPlaceToPage and dataPlacetoPage functions don't make a full-page image of the page, when inserting a downlink on a non-leaf page. The comment says: /* * Prev