Re: [HACKERS] Recommend wrappers of PG_DETOAST_DATUM_PACKED()

2017-02-27 Thread Noah Misch
On Tue, Oct 25, 2016 at 10:57:24AM -0400, Noah Misch wrote: > When commit 3e23b68dac006e8deb0afa327e855258df8de064 introduced single-byte > varlena headers, its fmgr.h changes presented PG_GETARG_TEXT_PP() and > PG_GETARG_TEXT_P() as equals. Its postgres.h changes presented > PG_DETOAST_DATUM_PACK

Re: [HACKERS] Recommend wrappers of PG_DETOAST_DATUM_PACKED()

2016-10-25 Thread Tom Lane
Noah Misch writes: > When commit 3e23b68dac006e8deb0afa327e855258df8de064 introduced single-byte > varlena headers, its fmgr.h changes presented PG_GETARG_TEXT_PP() and > PG_GETARG_TEXT_P() as equals. Its postgres.h changes presented > PG_DETOAST_DATUM_PACKED() and VARDATA_ANY() as the exceptiona

[HACKERS] Recommend wrappers of PG_DETOAST_DATUM_PACKED()

2016-10-25 Thread Noah Misch
When commit 3e23b68dac006e8deb0afa327e855258df8de064 introduced single-byte varlena headers, its fmgr.h changes presented PG_GETARG_TEXT_PP() and PG_GETARG_TEXT_P() as equals. Its postgres.h changes presented PG_DETOAST_DATUM_PACKED() and VARDATA_ANY() as the exceptional case. Let's firmly recomm