RE: [HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE

2000-12-05 Thread Larry Rosenman
enman; PostgreSQL Hackers List Subject: Re: [HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE Alfred Perlstein <[EMAIL PROTECTED]> writes: > Anyhow, to address the problem I've removed struct mount from > userland visibility in both FreeBSD 5.x (current) and FreeBSD 4.x >

Re: [HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE

2000-12-05 Thread Alfred Perlstein
* Tom Lane <[EMAIL PROTECTED]> [001205 07:14] wrote: > Alfred Perlstein <[EMAIL PROTECTED]> writes: > > Anyhow, to address the problem I've removed struct mount from > > userland visibility in both FreeBSD 5.x (current) and FreeBSD 4.x > > (stable). > > That might fix things on your box, but we c

Re: [HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE

2000-12-05 Thread Tom Lane
Alfred Perlstein <[EMAIL PROTECTED]> writes: > Anyhow, to address the problem I've removed struct mount from > userland visibility in both FreeBSD 5.x (current) and FreeBSD 4.x > (stable). That might fix things on your box, but we can hardly rely on it as an answer for everyone running FreeBSD :-

Re: [HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE

2000-12-05 Thread Larry Rosenman
* Alfred Perlstein <[EMAIL PROTECTED]> [001205 04:00]: > * Larry Rosenman <[EMAIL PROTECTED]> [001128 20:44] wrote: > > * Tom Lane <[EMAIL PROTECTED]> [001128 22:31]: > > > Larry Rosenman <[EMAIL PROTECTED]> writes: > > > > The last batch of commits break on FreeBSD 4.2-STABLE. > > > > /usr/inclu

Re: [HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE

2000-12-05 Thread Alfred Perlstein
* Larry Rosenman <[EMAIL PROTECTED]> [001128 20:44] wrote: > * Tom Lane <[EMAIL PROTECTED]> [001128 22:31]: > > Larry Rosenman <[EMAIL PROTECTED]> writes: > > > The last batch of commits break on FreeBSD 4.2-STABLE. > > > /usr/include/machine/lock.h:148: conflicting types for `s_lock' > > > ../..

Re: [HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE

2000-11-29 Thread Larry Rosenman
* Larry Rosenman <[EMAIL PROTECTED]> [001129 19:54]: > * Tom Lane <[EMAIL PROTECTED]> [001128 23:03]: > > Larry Rosenman <[EMAIL PROTECTED]> writes: > > >> We've called that routine s_lock for a *long* time, so it seems > > >> like there must be some factor involved that I don't see just yet... >

Re: [HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE

2000-11-29 Thread Larry Rosenman
* Tom Lane <[EMAIL PROTECTED]> [001128 23:03]: > Larry Rosenman <[EMAIL PROTECTED]> writes: > >> We've called that routine s_lock for a *long* time, so it seems > >> like there must be some factor involved that I don't see just yet... > > > Didn't your commit message say something about the TAS a

Re: [HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE

2000-11-28 Thread Larry Rosenman
* Alfred Perlstein <[EMAIL PROTECTED]> [001128 22:55]: > * Larry Rosenman <[EMAIL PROTECTED]> [001128 20:52] wrote: > > My offer stands for you as well, if you'd like an account > > on this P-III 600E, you are welcome to one... > > I just remebered my laptop in the other room, it's a pretty recen

Re: [HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE

2000-11-28 Thread Larry Rosenman
* Tom Lane <[EMAIL PROTECTED]> [001128 23:03]: > Larry Rosenman <[EMAIL PROTECTED]> writes: > >> We've called that routine s_lock for a *long* time, so it seems > >> like there must be some factor involved that I don't see just yet... > > > Didn't your commit message say something about the TAS a

[HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE

2000-11-28 Thread Tom Lane
Larry Rosenman <[EMAIL PROTECTED]> writes: >> We've called that routine s_lock for a *long* time, so it seems >> like there must be some factor involved that I don't see just yet... > Didn't your commit message say something about the TAS and NON-TAS > paths being the same now? Yeah, but don't

[HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE

2000-11-28 Thread Larry Rosenman
* Tom Lane <[EMAIL PROTECTED]> [001128 22:55]: > Larry Rosenman <[EMAIL PROTECTED]> writes: > >> Here is the "Current" /usr/include/machine/lock.h: > >> ... > >> void s_lock __P((struct simplelock *)); > >> ... > > Ick. Seems like the relevant question is not so much "why

[HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE

2000-11-28 Thread Tom Lane
Larry Rosenman <[EMAIL PROTECTED]> writes: >> Here is the "Current" /usr/include/machine/lock.h: >> ... >> void s_lock __P((struct simplelock *)); >> ... Ick. Seems like the relevant question is not so much "why did it break" as "how did it ever manage to work"? I have no probl

Re: [HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE

2000-11-28 Thread Alfred Perlstein
* Larry Rosenman <[EMAIL PROTECTED]> [001128 20:52] wrote: > My offer stands for you as well, if you'd like an account > on this P-III 600E, you are welcome to one... I just remebered my laptop in the other room, it's a pretty recent 4.2. I'll give it shot. Yes, it's possible to forget about a

Re: [HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE

2000-11-28 Thread Larry Rosenman
My offer stands for you as well, if you'd like an account on this P-III 600E, you are welcome to one... LER * Alfred Perlstein <[EMAIL PROTECTED]> [001128 22:46]: > * Larry Rosenman <[EMAIL PROTECTED]> [001128 20:44] wrote: > > * Tom Lane <[EMAIL PROTECTED]> [001128 22:31]: > > > Larry Rosenman <

Re: [HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE

2000-11-28 Thread Alfred Perlstein
* Larry Rosenman <[EMAIL PROTECTED]> [001128 20:44] wrote: > * Tom Lane <[EMAIL PROTECTED]> [001128 22:31]: > > Larry Rosenman <[EMAIL PROTECTED]> writes: > > > The last batch of commits break on FreeBSD 4.2-STABLE. > > > /usr/include/machine/lock.h:148: conflicting types for `s_lock' > > > ../..

[HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE

2000-11-28 Thread Larry Rosenman
* Tom Lane <[EMAIL PROTECTED]> [001128 22:31]: > Larry Rosenman <[EMAIL PROTECTED]> writes: > > The last batch of commits break on FreeBSD 4.2-STABLE. > > /usr/include/machine/lock.h:148: conflicting types for `s_lock' > > ../../../src/include/storage/s_lock.h:402: previous declaration of `s_lock

[HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE

2000-11-28 Thread Larry Rosenman
* Larry Rosenman <[EMAIL PROTECTED]> [001128 22:33]: > * Tom Lane <[EMAIL PROTECTED]> [001128 22:31]: > > Larry Rosenman <[EMAIL PROTECTED]> writes: > > > The last batch of commits break on FreeBSD 4.2-STABLE. > > > /usr/include/machine/lock.h:148: conflicting types for `s_lock' > > > ../../../sr

[HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE

2000-11-28 Thread Larry Rosenman
* Tom Lane <[EMAIL PROTECTED]> [001128 22:31]: > Larry Rosenman <[EMAIL PROTECTED]> writes: > > The last batch of commits break on FreeBSD 4.2-STABLE. > > /usr/include/machine/lock.h:148: conflicting types for `s_lock' > > ../../../src/include/storage/s_lock.h:402: previous declaration of `s_lock

[HACKERS] Re: LOCK Fixes/Break on FreeBSD 4.2-STABLE

2000-11-28 Thread Tom Lane
Larry Rosenman <[EMAIL PROTECTED]> writes: > The last batch of commits break on FreeBSD 4.2-STABLE. > /usr/include/machine/lock.h:148: conflicting types for `s_lock' > ../../../src/include/storage/s_lock.h:402: previous declaration of `s_lock' That's odd. s_lock has been declared the same way r