Re: [HACKERS] Re: [COMMITTERS] pgsql: Implement multivariate n-distinct coefficients

2017-03-24 Thread Tom Lane
Alvaro Herrera writes: > Tom Lane wrote: >> Why not use COSTS OFF? Or I'll put that even more strongly: all the >> existing regression tests use COSTS OFF, exactly to avoid this sort of >> machine-dependent output. There had better be a really damn good >> reason not to use it here. > If we use

Re: [HACKERS] Re: [COMMITTERS] pgsql: Implement multivariate n-distinct coefficients

2017-03-24 Thread Alvaro Herrera
Tom Lane wrote: > Why not use COSTS OFF? Or I'll put that even more strongly: all the > existing regression tests use COSTS OFF, exactly to avoid this sort of > machine-dependent output. There had better be a really damn good > reason not to use it here. If we use COSTS OFF, the test is complet

Re: [HACKERS] Re: [COMMITTERS] pgsql: Implement multivariate n-distinct coefficients

2017-03-24 Thread Tom Lane
Alvaro Herrera writes: > Robert Haas wrote: >> dromedary and arapaima have failures like this, which seems likely >> related to this commit: >> >> EXPLAIN >> SELECT COUNT(*) FROM ndistinct GROUP BY a, d; >> QUERY PLAN >> - >> !

[HACKERS] Re: [COMMITTERS] pgsql: Implement multivariate n-distinct coefficients

2017-03-24 Thread Alvaro Herrera
Robert Haas wrote: > On Fri, Mar 24, 2017 at 1:16 PM, Alvaro Herrera > wrote: > > Implement multivariate n-distinct coefficients > > dromedary and arapaima have failures like this, which seems likely > related to this commit: > > EXPLAIN >SELECT COUNT(*) FROM ndistinct GROUP BY a, d; >