Re: [HACKERS] REVIEW: PL/Python table functions

2011-02-26 Thread Peter Eisentraut
Committed the last version. I updated the documentation which previously claimed that what you implemented wasn't supported. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] REVIEW: PL/Python table functions

2011-02-08 Thread Hitoshi Harada
2011/2/9 Jan Urbański : > I hope this version does the right thing, while still avoiding the > performance hit of looking up I/O funcs every time a row is returned. > Actually, PL/Perl *does* look up the I/O funcs every time, so in the > worst case I can just drop this optimisation. But let's hope

Re: [HACKERS] REVIEW: PL/Python table functions

2011-02-08 Thread Jan Urbański
On 07/02/11 06:10, Hitoshi Harada wrote: > 2011/2/7 Jan Urbański : >> On 04/02/11 16:26, Hitoshi Harada wrote: >>> 2011/1/28 Jan Urbański : On 27/01/11 00:41, Jan Urbański wrote: > I'm also attaching an updated version that should apply on top of my > github refactor branch (or increme

Re: [HACKERS] REVIEW: PL/Python table functions

2011-02-06 Thread Hitoshi Harada
2011/2/7 Jan Urbański : > On 04/02/11 16:26, Hitoshi Harada wrote: >> 2011/1/28 Jan Urbański : >>> On 27/01/11 00:41, Jan Urbański wrote: I'm also attaching an updated version that should apply on top of my github refactor branch (or incrementally over the new set of refactor patches

Re: [HACKERS] REVIEW: PL/Python table functions

2011-02-06 Thread Jan Urbański
On 04/02/11 16:26, Hitoshi Harada wrote: > 2011/1/28 Jan Urbański : >> On 27/01/11 00:41, Jan Urbański wrote: >>> I'm also attaching an updated version that should apply on top of my >>> github refactor branch (or incrementally over the new set of refactor >>> patches that I will post shortly to th

Re: [HACKERS] REVIEW: PL/Python table functions

2011-02-04 Thread Hitoshi Harada
2011/1/28 Jan Urbański : > On 27/01/11 00:41, Jan Urbański wrote: >> I'm also attaching an updated version that should apply on top of my >> github refactor branch (or incrementally over the new set of refactor >> patches that I will post shortly to the refactor thread). > > Attached is a patch for

Re: [HACKERS] REVIEW: PL/Python table functions

2011-01-27 Thread Jan Urbański
On 27/01/11 00:41, Jan Urbański wrote: > I'm also attaching an updated version that should apply on top of my > github refactor branch (or incrementally over the new set of refactor > patches that I will post shortly to the refactor thread). Attached is a patch for master, as the refactorings have

Re: [HACKERS] REVIEW: PL/Python table functions

2011-01-26 Thread Jan Urbański
On 24/01/11 05:42, Hitoshi Harada wrote: > 2011/1/23 Jan Urbański : >> On 22/01/11 11:15, Hitoshi Harada wrote: > I tested the new incremental patch and the previous example works > fine. I don't know if this can be handled properly but another example > is: > > regression=# create function func1(

Re: [HACKERS] REVIEW: PL/Python table functions

2011-01-23 Thread Hitoshi Harada
2011/1/23 Jan Urbański : > On 22/01/11 11:15, Hitoshi Harada wrote: >> This is a review for >> https://commitfest.postgresql.org/action/patch_view?id=460 > > Thanks, > >> One issue is typmod of record type. >> >> regression=# create or replace function func1(t text) returns record >> as $$ return

Re: [HACKERS] REVIEW: PL/Python table functions

2011-01-22 Thread Jan Urbański
On 22/01/11 11:15, Hitoshi Harada wrote: > This is a review for > https://commitfest.postgresql.org/action/patch_view?id=460 Thanks, > One issue is typmod of record type. > > regression=# create or replace function func1(t text) returns record > as $$ return {'name': t, 'value': 0} $$ language

[HACKERS] REVIEW: PL/Python table functions

2011-01-22 Thread Hitoshi Harada
This is a review for https://commitfest.postgresql.org/action/patch_view?id=460 == Submission == The patch applies and compiles with success, on the top of the general refactor patch. It is possible it cannot in HEAD now that the part of the refactor patch applied in the core. I'll check it after