Re: [HACKERS] REASSIGN OWNED lacks support for FDWs

2012-02-23 Thread Etsuro Fujita
(2012/02/23 5:32), Alvaro Herrera wrote: My only concern on the patch is +static void +AlterForeignServerOwner_internal(Relation rel, HeapTuple tup, Oid newOwnerId) +{ +Form_pg_foreign_server form; -srvId = HeapTupleGetOid(tup); form = (Form_pg_foreign_server) GETSTRUCT(tup);

Re: [HACKERS] REASSIGN OWNED lacks support for FDWs

2012-02-22 Thread Alvaro Herrera
Excerpts from Tom Lane's message of mar feb 21 21:30:39 -0300 2012: > > Alvaro Herrera writes: > > Excerpts from Alvaro Herrera's message of mar feb 21 15:54:03 -0300 2012: > >> Excerpts from Tom Lane's message of lun feb 20 12:37:45 -0300 2012: > >>> As per http://archives.postgresql.org/pgsql-

Re: [HACKERS] REASSIGN OWNED lacks support for FDWs

2012-02-22 Thread Alvaro Herrera
Excerpts from Etsuro Fujita's message of mié feb 22 05:37:36 -0300 2012: > I did some tests. The results look good to me. Please find attached a > logfile. Thanks. > My only concern on the patch is > > +static void > +AlterForeignServerOwner_internal(Relation rel, HeapTuple tup, Oid > newOwn

Re: [HACKERS] REASSIGN OWNED lacks support for FDWs

2012-02-22 Thread Etsuro Fujita
(2012/02/22 9:30), Tom Lane wrote: > Alvaro Herrera writes: >> Excerpts from Alvaro Herrera's message of mar feb 21 15:54:03 -0300 2012: >>> Excerpts from Tom Lane's message of lun feb 20 12:37:45 -0300 2012: As per http://archives.postgresql.org/pgsql-general/2012-02/msg00304.php there

Re: [HACKERS] REASSIGN OWNED lacks support for FDWs

2012-02-21 Thread Tom Lane
Alvaro Herrera writes: > Excerpts from Alvaro Herrera's message of mar feb 21 15:54:03 -0300 2012: >> Excerpts from Tom Lane's message of lun feb 20 12:37:45 -0300 2012: >>> As per http://archives.postgresql.org/pgsql-general/2012-02/msg00304.php >>> there is no switch case in shdepReassignOwned f

Re: [HACKERS] REASSIGN OWNED lacks support for FDWs

2012-02-21 Thread Alvaro Herrera
Excerpts from Alvaro Herrera's message of mar feb 21 15:54:03 -0300 2012: > Excerpts from Tom Lane's message of lun feb 20 12:37:45 -0300 2012: > > Robert Haas writes: > > > On Wed, Feb 15, 2012 at 12:58 PM, Tom Lane wrote: > > >> As per http://archives.postgresql.org/pgsql-general/2012-02/msg003

Re: [HACKERS] REASSIGN OWNED lacks support for FDWs

2012-02-21 Thread Alvaro Herrera
Excerpts from Tom Lane's message of lun feb 20 12:37:45 -0300 2012: > Robert Haas writes: > > On Wed, Feb 15, 2012 at 12:58 PM, Tom Lane wrote: > >> As per http://archives.postgresql.org/pgsql-general/2012-02/msg00304.php > >> there is no switch case in shdepReassignOwned for foreign data wrappe

Re: [HACKERS] REASSIGN OWNED lacks support for FDWs

2012-02-20 Thread Tom Lane
Robert Haas writes: > On Wed, Feb 15, 2012 at 12:58 PM, Tom Lane wrote: >> As per http://archives.postgresql.org/pgsql-general/2012-02/msg00304.php >> there is no switch case in shdepReassignOwned for foreign data wrappers. >> >> The obvious short-term answer (and probably the only back-patchabl

Re: [HACKERS] REASSIGN OWNED lacks support for FDWs

2012-02-20 Thread Robert Haas
On Wed, Feb 15, 2012 at 12:58 PM, Tom Lane wrote: > As per http://archives.postgresql.org/pgsql-general/2012-02/msg00304.php > there is no switch case in shdepReassignOwned for foreign data wrappers. > > The obvious short-term answer (and probably the only back-patchable one) > is to add a case fo

[HACKERS] REASSIGN OWNED lacks support for FDWs

2012-02-15 Thread Tom Lane
As per http://archives.postgresql.org/pgsql-general/2012-02/msg00304.php there is no switch case in shdepReassignOwned for foreign data wrappers. The obvious short-term answer (and probably the only back-patchable one) is to add a case for that object type. But after all the refactoring that's be