[HACKERS] Re: A couple of fishy-looking critical sections

2001-01-19 Thread Tom Lane
"Mikheev, Vadim" <[EMAIL PROTECTED]> writes: >> 3. src/backend/access/transam/xlog.c, routine CreateCheckPoint: >> does this *entire* routine need to be a critical section? Again, >> I fear a shotgun approach will mean a net decrease in reliability, >> not an improvement. How much of this code r

[HACKERS] RE: A couple of fishy-looking critical sections

2001-01-19 Thread Mikheev, Vadim
> 1. src/backend/access/nbtree/nbtinsert.c, line 867: shouldn't this > END_CRIT_SECTION be moved up to before the _bt_wrtbuf call? It seems > to me that an elog during the wrtbuf is not a critical failure. If > this code is correct, then all the other crit sections are wrong, > because all of th