Re: [HACKERS] Quick coding question with acl fixes

2004-07-28 Thread Christopher Kings-Lynne
When I run through the acl changing all references from the old owner to the new owner, should I combine the resulting acls if possible? Because if the new owner already has some acls on that item, they will end up with two acls. If possible ... how painful would it be to do? I'm pretty close t

Re: [HACKERS] Quick coding question with acl fixes

2004-07-25 Thread Christopher Kings-Lynne
Yeah, but the point was that he was doing an ALTER OWNER and needed to fix the ACL to match. I thought he claimed to have written the needed subroutine. I have not yet looked at his patch though. I think Fabien's owner changing routine will end up being a strict subset of my routine. I think hi

Re: [HACKERS] Quick coding question with acl fixes

2004-07-24 Thread Tom Lane
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: >> BTW, are you sure Fabien did not already solve this problem in his >> pending patch? > You mean schema ownership? I thought that was just upon the first > connection to a database or something? Yeah, but the point was that he was doing an A

Re: [HACKERS] Quick coding question with acl fixes

2004-07-24 Thread Christopher Kings-Lynne
If possible ... how painful would it be to do? I'm yet to do that part, so I guess I'll find out. Actually it looks like you'd better, because for example aclupdate assumes there's only one entry for a given grantor/grantee pair. OK, many thanks for the prompt reply :) BTW, are you sure Fabien did

Re: [HACKERS] Quick coding question with acl fixes

2004-07-24 Thread Tom Lane
Tom Lane <[EMAIL PROTECTED]> writes: > Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: >> When I run through the acl changing all references from the old owner to >> the new owner, should I combine the resulting acls if possible? Because >> if the new owner already has some acls on that item

Re: [HACKERS] Quick coding question with acl fixes

2004-07-24 Thread Tom Lane
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > If I have the nspForm variable (which is a Form_pg_namespace) struct > pointer, then how do I check if the nspacl field is default (ie. > "NULL"). This is so I can avoid running DatumGetAclP on it, which seems > to cause alloc error reports.

[HACKERS] Quick coding question with acl fixes

2004-07-24 Thread Christopher Kings-Lynne
Hi, Usually i'd ply away at this one until I figured it out, but we're running out of time :) If I have the nspForm variable (which is a Form_pg_namespace) struct pointer, then how do I check if the nspacl field is default (ie. "NULL"). This is so I can avoid running DatumGetAclP on it, which