Re: [HACKERS] Proposed changes to DTrace probe implementation

2008-02-27 Thread Paul van den Bogaard
but putting these and other counters in context is what could be missing. Correlating a given (set of) stats with others (possible outside of the application domain) is one of the assets offered by DTrace. Besides the generic transaction begin/start/end it could also be helpful to see the

Re: [HACKERS] Proposed changes to DTrace probe implementation

2008-02-27 Thread Magnus Hagander
On Tue, Feb 26, 2008 at 03:48:28PM -0600, Robert Lor wrote: > Gregory Stark wrote: > >I think both types of probes are useful to different people. > > > I think certain higher level probes can be really useful to DBAs. > >Perhaps looking at the standard database SNMP MIB counters would give us a

Re: [HACKERS] Proposed changes to DTrace probe implementation

2008-02-26 Thread Robert Lor
Tom Lane wrote: The concern I've got about this is basically that it would encourage plastering the same label on subtly different counts, leading to confusion and perhaps mistaken conclusions. I would prefer to see any common probes be reverse-engineered *after the fact*, ie, after you've alrea

Re: [HACKERS] Proposed changes to DTrace probe implementation

2008-02-26 Thread Tom Lane
Robert Lor <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> I'm unimpressed; it's not at all clear that you'd be measuring quite the >> same thing in, say, mysql as in postgres. > I think it depends on the probe, but for transaction rates like start or > commit, don't you think it's pretty black

Re: [HACKERS] Proposed changes to DTrace probe implementation

2008-02-26 Thread Robert Lor
Gregory Stark wrote: I think both types of probes are useful to different people. I think certain higher level probes can be really useful to DBAs. Perhaps looking at the standard database SNMP MIB counters would give us a place to start for upward facing events people want to trace for data

Re: [HACKERS] Proposed changes to DTrace probe implementation

2008-02-26 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > Possibly I have a different view of the uses of dtrace than you do, but > most of the events I'd be interested in probing are probably pretty > Postgres-specific. I think both types of probes are useful to different people. One of the really neat things

Re: [HACKERS] Proposed changes to DTrace probe implementation

2008-02-26 Thread Robert Lor
Tom Lane wrote: I'm unimpressed; it's not at all clear that you'd be measuring quite the same thing in, say, mysql as in postgres. I think it depends on the probe, but for transaction rates like start or commit, don't you think it's pretty black & white as long as the probes are placed in th

Re: [HACKERS] Proposed changes to DTrace probe implementation

2008-02-26 Thread Tom Lane
Robert Lor <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> I'm unconvinced that there will be any probes that are common to all >> databases. I'd skip this part... >> > Any reason why we can't consider probes like transaction-start, > transaction-commit, or transaction-abort as common probes th

Re: [HACKERS] Proposed changes to DTrace probe implementation

2008-02-26 Thread Robert Lor
Tom Lane wrote: I'm unconvinced that there will be any probes that are common to all databases. I'd skip this part... Any reason why we can't consider probes like transaction-start, transaction-commit, or transaction-abort as common probes that can also be used in other (maybe no all) data

Re: [HACKERS] Proposed changes to DTrace probe implementation

2008-02-26 Thread Tom Lane
Robert Lor <[EMAIL PROTECTED]> writes: >> * This is unrelated to making DTrace work on Leopard, but I'd like to >> propose that we split the probes into generic database and Postgres >> specific providers, called "database" and "postgresql" respectively. >> Other databases will be adding DTrace

Re: [HACKERS] Proposed changes to DTrace probe implementation

2008-02-26 Thread Robert Lor
Robert Lor wrote: Proposed changes: * Switch from using DTRACE_PROBEn macros to the dynamically generated macros (remove pg_trace.h) * Use "dtrace -h" to create a header file that contains the dynamically generated macros to be used in the source code instead of the DTRACE_PROBEn macros. * Cre

Re: [HACKERS] Proposed changes to DTrace probe implementation

2008-02-22 Thread Robert Lor
Robert Lor <[EMAIL PROTECTED]> wrote: > Peter, > > Peter Eisentraut <[EMAIL PROTECTED]> wrote: > > Could you please use diff -c or -u for the patch? It's quite hard > to > > read this way. > > Attached is the patch with diff -c. > Oops, here's the real attachment! Regards, -Robert dtrac

Re: [HACKERS] Proposed changes to DTrace probe implementation

2008-02-22 Thread Robert Lor
Peter, Peter Eisentraut <[EMAIL PROTECTED]> wrote: > Could you please use diff -c or -u for the patch? It's quite hard to > read this way. Attached is the patch with diff -c. Thanks, -Robert ---(end of broadcast)--- TIP 3: Have you checked our e

Re: [HACKERS] Proposed changes to DTrace probe implementation

2008-02-22 Thread Peter Eisentraut
Am Freitag, 22. Februar 2008 schrieb Robert Lor: > Preliminary patch is attached. Could you please use diff -c or -u for the patch? It's quite hard to read this way. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)-

[HACKERS] Proposed changes to DTrace probe implementation

2008-02-22 Thread Robert Lor
Motivation: To enable probes to work with Mac OS X Leopard and other OSes that will support DTrace in the future. Bug filed on this issue http://archives.postgresql.org/pgsql-bugs/2007-10/msg00201.php The problem: There are two different mechanisms to implementing application level probes in