Re: [HACKERS] Postgresql coding conventions

2008-09-11 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > Abbas <[EMAIL PROTECTED]> writes: >> While writing code or reviewing a path are we supposed to consider the >> camel cased names correct or the under-score separated names correct? > Some parts of the code use the two to distinguish between functions loc

Re: [HACKERS] Postgresql coding conventions

2008-09-11 Thread Gregory Stark
Abbas <[EMAIL PROTECTED]> writes: > While writing code or reviewing a path are we supposed to consider the > camel cased names correct or the under-score separated names correct? Some parts of the code use the two to distinguish between functions local to that module and functions that are part

Re: [HACKERS] Postgresql coding conventions

2008-09-11 Thread Andrew Dunstan
Abbas wrote: Hi, I have noticed two different coding conventions being followed in postgres code base. See e.g. function names in syslogger.c static void set_next_rotation_time(void); static void sigHupHandler(SIGNAL_ARGS); and variable names in the same file int bytes_in_logbuffer = 0;

Re: [HACKERS] Postgresql coding conventions

2008-09-11 Thread Heikki Linnakangas
Abbas wrote: I have noticed two different coding conventions being followed in postgres code base. See e.g. function names in syslogger.c static void set_next_rotation_time(void); static void sigHupHandler(SIGNAL_ARGS); and variable names in the same file int bytes_in_logbuffer = 0; char

[HACKERS] Postgresql coding conventions

2008-09-11 Thread Abbas
Hi, I have noticed two different coding conventions being followed in postgres code base. See e.g. function names in syslogger.c static void set_next_rotation_time(void); static void sigHupHandler(SIGNAL_ARGS); and variable names in the same file int bytes_in_logbuffer = 0; char*current