While at it the assert(cnfa != NULL && cnfa->nstates != 0); at
src/backend/regex/rege_dfa.c:282
is issued too late indeed at line 278 and 279 cnfa was already
dereferenced.
Same for assert(t != NULL) in src/backend/regex/regexec.c:821 is issued way
too late.
On Thu, 28 May 2015 at 15:59 Tom
Robert Haas writes:
> On Wed, May 27, 2015 at 8:57 PM, Haribabu Kommi
> wrote:
>> By correcting the following way will solve the problem.
>> return ts ? (*ts != 0) : false; instead of retun *ts != 0;
>> Attached a patch for it.
> If the only caller always passes a valid pointer, there's no point
On Wed, May 27, 2015 at 8:57 PM, Haribabu Kommi
wrote:
> On Thu, May 28, 2015 at 6:07 AM, Gaetano Mendola wrote:
>> I'm playing with a static analyzer and it's giving out some real error
>> analyzing postgresql code base like the following one
>>
>> src/backend/access/transam/commit_ts.c
>>re
On Thu, May 28, 2015 at 6:07 AM, Gaetano Mendola wrote:
> I'm playing with a static analyzer and it's giving out some real error
> analyzing postgresql code base like the following one
>
> src/backend/access/transam/commit_ts.c
>return *ts != 0 // line 321
> but a few line up (line 315) ts is
I'm playing with a static analyzer and it's giving out some real error
analyzing postgresql code base like the following one
src/backend/access/transam/commit_ts.c
return *ts != 0 // line 321
but a few line up (line 315) ts is checked for null, so either is not
needed to check for null or *ts
