Re: [HACKERS] Possible PANIC in PostPrepare_Locks

2013-01-13 Thread Tom Lane
Heikki Linnakangas writes: > On 11.01.2013 04:16, Tom Lane wrote: >> Also, it looks like we'll need two code paths in PostPrepare_Locks to >> deal with the possibility that a conflicting entry already exists? >> I'm not sure this is possible, but I'm not sure it's not, either. > If I understand t

Re: [HACKERS] Possible PANIC in PostPrepare_Locks

2013-01-11 Thread Heikki Linnakangas
On 11.01.2013 04:16, Tom Lane wrote: [explanation of a race condition] Good catch. Also, it looks like we'll need two code paths in PostPrepare_Locks to deal with the possibility that a conflicting entry already exists? I'm not sure this is possible, but I'm not sure it's not, either. If I

[HACKERS] Possible PANIC in PostPrepare_Locks

2013-01-10 Thread Tom Lane
While looking at the lock code the other day, I noticed this comment in PostPrepare_Locks(): /* * We cannot simply modify proclock->tag.myProc to reassign * ownership of the lock, because that's part of the hash key and * the proclock would then b