Re: [HACKERS] Possible Bug in pg_upgrade

2011-08-15 Thread Bruce Momjian
Applied. --- Bruce Momjian wrote: > Dave Byrne wrote: > > Beginning with commit 002c105a0706bd1c1e939fe0f47ecdceeae6c52d > > pg_upgrade will fail if there are orphaned temp tables in the current > > database with the message

Re: [HACKERS] Possible Bug in pg_upgrade

2011-08-14 Thread Bruce Momjian
Dave Byrne wrote: > Beginning with commit 002c105a0706bd1c1e939fe0f47ecdceeae6c52d > pg_upgrade will fail if there are orphaned temp tables in the current > database with the message 'old and new databases "postgres" have a > different number of relations' > > On line 41 of pg_upgrade/info.c pg_up

Re: [HACKERS] Possible Bug in pg_upgrade

2011-08-12 Thread Dave Byrne
On 08/11/2011 12:02 AM, Peter Eisentraut wrote: On ons, 2011-08-10 at 18:53 -0400, Tom Lane wrote: Dave Byrne writes: Attached is a patch that skips orphaned temporary relations in pg_upgrade if they are lingering around. It works for 9.0 -> 9.1 upgrades, however I wasn't able to tell when

Re: [HACKERS] Possible Bug in pg_upgrade

2011-08-11 Thread Peter Eisentraut
On ons, 2011-08-10 at 18:53 -0400, Tom Lane wrote: > Dave Byrne writes: > > Attached is a patch that skips orphaned temporary relations in pg_upgrade > > if they are lingering around. It works for 9.0 -> 9.1 upgrades, however I > > wasn't able to tell when pg_class.relistemp was added so if it w

Re: [HACKERS] Possible Bug in pg_upgrade

2011-08-10 Thread Tom Lane
Dave Byrne writes: > Attached is a patch that skips orphaned temporary relations in pg_upgrade if > they are lingering around. It works for 9.0 -> 9.1 upgrades, however I wasn't > able to tell when pg_class.relistemp was added so if it was unavailable in > versions prior to 9.0 an additional ch

Re: [HACKERS] Possible Bug in pg_upgrade

2011-08-10 Thread Dave Byrne
be added. Thanks Dave Byrne -Original Message- From: Tom Lane [mailto:t...@sss.pgh.pa.us] Sent: Wednesday, August 10, 2011 12:29 PM To: Dave Byrne Cc: pgsql-hackers@postgresql.org; Bruce Momjian Subject: Re: [HACKERS] Possible Bug in pg_upgrade Dave Byrne writes: > Beginning

Re: [HACKERS] Possible Bug in pg_upgrade

2011-08-10 Thread Tom Lane
Dave Byrne writes: > Beginning with commit 002c105a0706bd1c1e939fe0f47ecdceeae6c52d > pg_upgrade will fail if there are orphaned temp tables in the current > database with the message 'old and new databases "postgres" have a > different number of relations' > On line 41 of pg_upgrade/info.c pg_up

[HACKERS] Possible Bug in pg_upgrade

2011-08-10 Thread Dave Byrne
Beginning with commit 002c105a0706bd1c1e939fe0f47ecdceeae6c52d pg_upgrade will fail if there are orphaned temp tables in the current database with the message 'old and new databases "postgres" have a different number of relations' On line 41 of pg_upgrade/info.c pg_upgrade checks that the number