Re: [HACKERS] Please rename split(text,text,int) to splitpart

2002-09-10 Thread Joe Conway
Bruce Momjian wrote: > Tom Lane wrote: >>That sounds like massive overkill. Just apply the patch. We don't need >>to institutionalize a regression test for this. > > It would catch people who don't apply the patch. We could remove the > test after 7.3. Just an idea. > The existing strings r

Re: [HACKERS] Please rename split(text,text,int) to splitpart

2002-09-10 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I am not either. How do you do the documentation when the function can > > be called two ways. > > You don't. There is only one supported name, so that's the only one > you document. > > > I guess we can give the SQL query to fix

Re: [HACKERS] Please rename split(text,text,int) to splitpart

2002-09-10 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I am not either. How do you do the documentation when the function can > be called two ways. You don't. There is only one supported name, so that's the only one you document. > I guess we can give the SQL query to fix it during > beta2 _and_ add a re

Re: [HACKERS] Please rename split(text,text,int) to splitpart

2002-09-10 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > What do people think if this change? > > I'm not thrilled about renaming the function without forcing an initdb > ... but the alternatives seem worse. Okay by me if we do it. I am not either. How do you do the documentation when t

Re: [HACKERS] Please rename split(text,text,int) to splitpart

2002-09-10 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > What do people think if this change? I'm not thrilled about renaming the function without forcing an initdb ... but the alternatives seem worse. Okay by me if we do it. regards, tom lane ---(end of broa

Re: [HACKERS] Please rename split(text,text,int) to splitpart

2002-09-10 Thread Joe Conway
Christopher Kings-Lynne wrote: > I think it should be made. Don't force an initdb. Beta testers can run the > update. 'split' is a pretty standard function these days... > Me too. Patch already sent in, including doc and regression test. And as I said, I'll take a TODO to create a 'split' wh

Re: [HACKERS] Please rename split(text,text,int) to splitpart

2002-09-10 Thread Christopher Kings-Lynne
esday, 11 September 2002 10:33 AM > To: Hannu Krosing > Cc: [EMAIL PROTECTED] > Subject: Re: [HACKERS] Please rename split(text,text,int) to splitpart > > > > What do people think if this change? > > -- > --

Re: [HACKERS] Please rename split(text,text,int) to splitpart

2002-09-10 Thread Bruce Momjian
What do people think if this change? --- Hannu Krosing wrote: > > It seems that my last mail on this did not get through to the list ;( > > > > Please consider renaming the new builtin function > > split(text,text,i

Re: [HACKERS] Please rename split(text,text,int) to splitpart

2002-09-05 Thread Joe Conway
Hannu Krosing wrote: > It seems that my last mail on this did not get through to the list ;( > > Please consider renaming the new builtin function > > split(text,text,int) > > to something else, perhaps > > split_part(text,text,int) > > (like date_part) > > The reason for this request i

[HACKERS] Please rename split(text,text,int) to splitpart

2002-09-04 Thread Hannu Krosing
It seems that my last mail on this did not get through to the list ;( Please consider renaming the new builtin function split(text,text,int) to something else, perhaps split_part(text,text,int) (like date_part) The reason for this request is that 3 most popular scripting languages (p