Re: [HACKERS] Pl/pgsql functions causing crashes in 8.2.2

2007-02-06 Thread Marko Kreen
On 2/6/07, Tom Lane <[EMAIL PROTECTED]> wrote: "Marko Kreen" <[EMAIL PROTECTED]> writes: > Attached is a patch for uniqueindent-0.2 that removes the > buggy checks and makes functions STRICT IMMUTABLE. Not sure where you should send that, but it's not here. I did Cc: the maintainer. -- marko

[HACKERS] Pl/pgsql functions causing crashes in 8.2.2

2007-02-06 Thread Jonathan Gray
Following an upgrade to 8.2.2, many of my plpgsql functions started to cause server process crashes. I make use of a custom data-type "uniqueidentifier", available here: http://gborg.postgresql.org/project/uniqueidentifier ftp://gborg.postgresql.org/pub/uniqueidentifier/stable/uniqueidentifier-0.

Re: [HACKERS] Pl/pgsql functions causing crashes in 8.2.2

2007-02-06 Thread Tom Lane
"Marko Kreen" <[EMAIL PROTECTED]> writes: > On 2/6/07, Marko Kreen <[EMAIL PROTECTED]> wrote: >> STRICT IMMUTABLE fixed the crash for me so seems it was bug >> in the module. Although it did not happen in 8.2.1 so seems >> some change in 8.2.2 made it trigger. > Trigger was following patch: > htt

Re: [HACKERS] Pl/pgsql functions causing crashes in 8.2.2

2007-02-06 Thread Tom Lane
"Marko Kreen" <[EMAIL PROTECTED]> writes: > Attached is a patch for uniqueindent-0.2 that removes the > buggy checks and makes functions STRICT IMMUTABLE. Not sure where you should send that, but it's not here. regards, tom lane ---(end of broadcas

Re: [HACKERS] Pl/pgsql functions causing crashes in 8.2.2

2007-02-06 Thread Marko Kreen
On 2/6/07, Marko Kreen <[EMAIL PROTECTED]> wrote: STRICT IMMUTABLE fixed the crash for me so seems it was bug in the module. Although it did not happen in 8.2.1 so seems some change in 8.2.2 made it trigger. Trigger was following patch: http://archives.postgresql.org/pgsql-committers/2007-02/

Re: [HACKERS] Pl/pgsql functions causing crashes in 8.2.2

2007-02-06 Thread Marko Kreen
On 2/6/07, Marko Kreen <[EMAIL PROTECTED]> wrote: Indeed, the code can crash on NULL values as the NULL checks are missing or wrong in the functions. Actually all the various functions except newid() should be declared STRICT IMMUTABLE thus immidiately avoiding problems with NULLs. Could you re

Re: [HACKERS] Pl/pgsql functions causing crashes in 8.2.2

2007-02-06 Thread Richard Huxton
[EMAIL PROTECTED] wrote: Reading the post again I caught a typo in my query. I had been playing with variations of this test to try and get it working, but I have had no success with any combination as long as it returns this kind of type. I was comparing integers to uniqueidentiers, which actu

Re: [HACKERS] Pl/pgsql functions causing crashes in 8.2.2

2007-02-06 Thread Marko Kreen
On 2/6/07, Jonathan Gray <[EMAIL PROTECTED]> wrote: Following an upgrade to 8.2.2, many of my plpgsql functions started to cause server process crashes. I make use of a custom data-type "uniqueidentifier", available here: http://gborg.postgresql.org/project/uniqueidentifier ftp://gborg.postgres

Re: [HACKERS] Pl/pgsql functions causing crashes in 8.2.2

2007-02-06 Thread jon5pg
Reading the post again I caught a typo in my query. I had been playing with variations of this test to try and get it working, but I have had no success with any combination as long as it returns this kind of type. I was comparing integers to uniqueidentiers, which actually works, but is unrelate

[HACKERS] Pl/pgsql functions causing crashes in 8.2.2

2007-02-06 Thread Jonathan Gray
Following an upgrade to 8.2.2, many of my plpgsql functions started to cause server process crashes. I make use of a custom data-type "uniqueidentifier", available here: http://gborg.postgresql.org/project/uniqueidentifier ftp://gborg.postgresql.org/pub/uniqueidentifier/stable/uniqueidentifier-0.