Re: [HACKERS] Pause/Resume feature for Hot Standby

2010-05-04 Thread Simon Riggs
On Tue, 2010-05-04 at 13:23 -0400, Tom Lane wrote: > * max_standby_delay logic is broken, as per other thread. Proposed fix submitted, > * handle_standby_sig_alarm is broken to the point of needing to be > thrown away; you can NOT do that kind of thing in an interrupt handler. This was modelled

Re: [HACKERS] Pause/Resume feature for Hot Standby

2010-05-04 Thread Simon Riggs
On Tue, 2010-05-04 at 13:23 -0400, Tom Lane wrote: > Simon Riggs writes: > > There hasn't been anything more than a minor bug in weeks, so not really > > sure how you arrive at that the idea the code needs "stabilising". > > Simon, if you don't think the code needs stabilizing, you need to think

Re: [HACKERS] Pause/Resume feature for Hot Standby

2010-05-04 Thread Tom Lane
Simon Riggs writes: > There hasn't been anything more than a minor bug in weeks, so not really > sure how you arrive at that the idea the code needs "stabilising". Simon, if you don't think the code needs stabilizing, you need to think again. * max_standby_delay logic is broken, as per other th

Re: [HACKERS] Pause/Resume feature for Hot Standby

2010-05-04 Thread Robert Haas
On Tue, May 4, 2010 at 11:10 AM, Simon Riggs wrote: > This is clearly a response to issues raised about HS and not a new > feature. I don't find that clear at all. In fact, I find the exact opposition position to be clear. > It's also proposed in the most minimal way possible with > respect for

Re: [HACKERS] Pause/Resume feature for Hot Standby

2010-05-04 Thread Simon Riggs
On Tue, 2010-05-04 at 11:12 -0400, Tom Lane wrote: > Simon Riggs writes: > > In the original patch I had Pause/Resume feature for controlling > > recovery during Hot Standby. It was removed for lack of time. > > > With all the discussion around the HS UI, it would be something that > > could be b

Re: [HACKERS] Pause/Resume feature for Hot Standby

2010-05-04 Thread Tom Lane
Simon Riggs writes: > In the original patch I had Pause/Resume feature for controlling > recovery during Hot Standby. It was removed for lack of time. > With all the discussion around the HS UI, it would be something that > could be back very easily. Sure. In 9.1. You have enough bugs to fix t

Re: [HACKERS] Pause/Resume feature for Hot Standby

2010-05-04 Thread Simon Riggs
On Tue, 2010-05-04 at 09:36 -0400, Robert Haas wrote: > On Tue, May 4, 2010 at 4:02 AM, Simon Riggs wrote: > > In the original patch I had Pause/Resume feature for controlling > > recovery during Hot Standby. It was removed for lack of time. > > Well, it's not like we have more time now than we

Re: [HACKERS] Pause/Resume feature for Hot Standby

2010-05-04 Thread Robert Haas
On Tue, May 4, 2010 at 4:02 AM, Simon Riggs wrote: > In the original patch I had Pause/Resume feature for controlling > recovery during Hot Standby. It was removed for lack of time. Well, it's not like we have more time now than we did then. I think we need to postpone this discussion to 9.1. I

Re: [HACKERS] Pause/Resume feature for Hot Standby

2010-05-04 Thread Dimitri Fontaine
Simon Riggs writes: > In the original patch I had Pause/Resume feature for controlling > recovery during Hot Standby. It was removed for lack of time. > > With all the discussion around the HS UI, it would be something that > could be back very easily. Please! Manual control over recovery is th

[HACKERS] Pause/Resume feature for Hot Standby

2010-05-04 Thread Simon Riggs
In the original patch I had Pause/Resume feature for controlling recovery during Hot Standby. It was removed for lack of time. With all the discussion around the HS UI, it would be something that could be back very easily. I would like to do it as a recovery control plugin. The plugin would be p