On Thu, Jun 14, 2012 at 3:20 PM, Robert Haas wrote:
> Also, you had
> the same primary content for both comments, and you incorrectly
> reversed the sense of the FreeFile() test.
>
I am known for my fat fingers :)
> Committed with those changes.
>
Thanks!
--
Gurjeet Singh
EnterpriseDB Corpor
On Thu, Jun 14, 2012 at 3:10 PM, Gurjeet Singh wrote:
>> Well, according to the comments for AllocateFile:
>>
>> * fd.c will automatically close all files opened with AllocateFile at
>> * transaction commit or abort; this prevents FD leakage if a routine
>> * that calls AllocateFile is terminat
On Thu, Jun 14, 2012 at 2:02 PM, Robert Haas wrote:
> On Thu, Jun 14, 2012 at 1:48 PM, Gurjeet Singh
> wrote:
> > On Thu, Jun 14, 2012 at 1:29 PM, Robert Haas
> wrote:
> >> Committed.
> >
> >
> > A minor gripe:
> >
> > + /*
> > + * Close the backup label file.
> > + */
> > + if
On Thu, Jun 14, 2012 at 2:05 PM, Fujii Masao wrote:
> On Fri, Jun 15, 2012 at 2:29 AM, Robert Haas wrote:
>> On Thu, Jun 14, 2012 at 6:06 AM, Gabriele Bartolini
>> wrote:
>>> thank you very much for your patience (and thank you Marco for supporting
>>> me). I apologise for the delay.
>>>
>>>
On Fri, Jun 15, 2012 at 2:29 AM, Robert Haas wrote:
> On Thu, Jun 14, 2012 at 6:06 AM, Gabriele Bartolini
> wrote:
>> thank you very much for your patience (and thank you Marco for supporting
>> me). I apologise for the delay.
>>
>> I have retested the updated patch and it works fine with m
On Thu, Jun 14, 2012 at 1:48 PM, Gurjeet Singh wrote:
> On Thu, Jun 14, 2012 at 1:29 PM, Robert Haas wrote:
>>
>> On Thu, Jun 14, 2012 at 6:06 AM, Gabriele Bartolini
>> wrote:
>> > thank you very much for your patience (and thank you Marco for
>> > supporting
>> > me). I apologise for the del
On Thu, Jun 14, 2012 at 1:29 PM, Robert Haas wrote:
> On Thu, Jun 14, 2012 at 6:06 AM, Gabriele Bartolini
> wrote:
> >thank you very much for your patience (and thank you Marco for
> supporting
> > me). I apologise for the delay.
> >
> >I have retested the updated patch and it works fine
On Thu, Jun 14, 2012 at 6:06 AM, Gabriele Bartolini
wrote:
> thank you very much for your patience (and thank you Marco for supporting
> me). I apologise for the delay.
>
> I have retested the updated patch and it works fine with me. It is "ready
> for committer" for me.
Committed.
--
Rob
Hello Gilles,
thank you very much for your patience (and thank you Marco for
supporting me). I apologise for the delay.
I have retested the updated patch and it works fine with me. It is
"ready for committer" for me.
Cheers,
Gabriele
Il 14/06/12 11:36, Marco Nenciarini ha scritto:
Hi Gilles,
unfortunately Gabriele has been very busy recently and he asked me to
check again the status of this patch for this commit fest. In order to
speed up the application of the patch, I am sending an updated version
which correctly compiles with current head. Gabriele will then proceed
with
Sorry for the the double post but it seems that my previous reply
doesn't reach the pgsql-hacker list. So here is the new patches that
limit lines to 80 characters.
Regards,
Le 02/05/2012 19:53, Gabriele Bartolini a écrit :
> Hi Gilles,
>
>Sorry for the delay.
>
> Il 03/04/12 14:21, Gilles Da
Hi Gilles,
Sorry for the delay.
Il 03/04/12 14:21, Gilles Darold ha scritto:
+1, this is also my point of view.
I have looked at the patch that contains both pg_is_in_backup() and
pg_backup_start_time().
From a functional point of view it looks fine to me. I was thinking
of addin
Hi Gabriele,
Le 31/03/2012 14:25, Gabriele Bartolini a écrit :
> Hi Gilles,
>
>first and foremost, sorry for jumping in this thread so late. I
> read all previous discussions and I'd be happy to help you with this
> patch.
>
>> Agreed and sorry for the response delay. I've attached 2 patches
>
Hi Gilles,
first and foremost, sorry for jumping in this thread so late. I read
all previous discussions and I'd be happy to help you with this patch.
Agreed and sorry for the response delay. I've attached 2 patches here,
the first one is the same as before with just the renaming of the
f
Le 03/02/2012 10:52, Magnus Hagander a écrit :
> On Fri, Feb 3, 2012 at 10:47, Fujii Masao wrote:
>> On Fri, Feb 3, 2012 at 6:10 PM, Bernd Helmle wrote:
>>>
>>> --On 3. Februar 2012 13:21:11 +0900 Fujii Masao
>>> wrote:
>>>
It seems to be more user-friendly to introduce a view like pg_stat_
On Fri, Feb 3, 2012 at 6:52 PM, Magnus Hagander wrote:
> On Fri, Feb 3, 2012 at 10:47, Fujii Masao wrote:
>> On Fri, Feb 3, 2012 at 6:10 PM, Bernd Helmle wrote:
>>>
>>>
>>> --On 3. Februar 2012 13:21:11 +0900 Fujii Masao
>>> wrote:
>>>
It seems to be more user-friendly to introduce a view
On Fri, Feb 3, 2012 at 10:47, Fujii Masao wrote:
> On Fri, Feb 3, 2012 at 6:10 PM, Bernd Helmle wrote:
>>
>>
>> --On 3. Februar 2012 13:21:11 +0900 Fujii Masao
>> wrote:
>>
>>> It seems to be more user-friendly to introduce a view like pg_stat_backup
>>> rather than the function returning an arr
On Fri, Feb 3, 2012 at 6:10 PM, Bernd Helmle wrote:
>
>
> --On 3. Februar 2012 13:21:11 +0900 Fujii Masao
> wrote:
>
>> It seems to be more user-friendly to introduce a view like pg_stat_backup
>> rather than the function returning an array.
>
>
> I like this idea. A use case i saw for monitoring
--On 3. Februar 2012 13:21:11 +0900 Fujii Masao wrote:
It seems to be more user-friendly to introduce a view like pg_stat_backup
rather than the function returning an array.
I like this idea. A use case i saw for monitoring backup_label's in the past,
was mainly to discover a forgotten exc
On Fri, Feb 3, 2012 at 11:31 AM, Euler Taveira de Oliveira
wrote:
> On 02-02-2012 20:06, Magnus Hagander wrote:
>> If there is more than one concurrent backup running, which one do you
>> return? The first one or the latest one? Or perhaps you need an
>> interface thta can return them all...
>>
>
On 02-02-2012 20:06, Magnus Hagander wrote:
> If there is more than one concurrent backup running, which one do you
> return? The first one or the latest one? Or perhaps you need an
> interface thta can return them all...
>
IMHO, pg_is_in_backup() should return true if one or more backup copies ar
On Thu, Feb 2, 2012 at 12:23, Marti Raudsepp wrote:
> On Mon, Jan 30, 2012 at 20:33, Gilles Darold wrote:
>> After some time searching for a Pg system administration function like
>> pg_is_in_recovery(), let's say pg_is_in_backup(), I couldn't find one.
>> The minor patch attached here adds this
--On 2. Februar 2012 18:47:35 +0100 Gilles Darold
wrote:
For now the internal function BackupInProgress() only return a boolean.
I like the idea that pg_is_in_backup() just works as pg_is_in_recovery()
do. I mean it doesn't return the timestamp of the recovery starting time
but only true or
Le 02/02/2012 12:23, Marti Raudsepp a écrit :
> On Mon, Jan 30, 2012 at 20:33, Gilles Darold wrote:
>> After some time searching for a Pg system administration function like
>> pg_is_in_recovery(), let's say pg_is_in_backup(), I couldn't find one.
>> The minor patch attached here adds this adminis
2012/2/2 Marti Raudsepp :
> On Mon, Jan 30, 2012 at 20:33, Gilles Darold wrote:
>> After some time searching for a Pg system administration function like
>> pg_is_in_recovery(), let's say pg_is_in_backup(), I couldn't find one.
>> The minor patch attached here adds this administrative function tha
On Mon, Jan 30, 2012 at 20:33, Gilles Darold wrote:
> After some time searching for a Pg system administration function like
> pg_is_in_recovery(), let's say pg_is_in_backup(), I couldn't find one.
> The minor patch attached here adds this administrative function that can
> be used with others bac
Le 30/01/2012 22:14, Euler Taveira de Oliveira a écrit :
> On 30-01-2012 15:33, Gilles Darold wrote:
>> Yesterday I was facing a little issue with a backup software (NetBackup)
>> that do not report error when a post backup script is run. The problem
>> is that this script execute pg_stop_backup()
On 30-01-2012 15:33, Gilles Darold wrote:
> Yesterday I was facing a little issue with a backup software (NetBackup)
> that do not report error when a post backup script is run. The problem
> is that this script execute pg_stop_backup() and if there's any failure
> PostgreSQL keeps running in on-li
Hello,
Yesterday I was facing a little issue with a backup software (NetBackup)
that do not report error when a post backup script is run. The problem
is that this script execute pg_stop_backup() and if there's any failure
PostgreSQL keeps running in on-line backup mode. So the backup is not
compl
29 matches
Mail list logo
