Re: [HACKERS] Patch for fixing a few memory leaks

2001-10-06 Thread Tom Lane
Teodor Sigaev <[EMAIL PROTECTED]> writes: >>> Tom, I want to notice that initGISTstate is called for every inserting >>> value (for each row). I think it's not good, because this function >>> called 'fmgr_info' 7 times. 'fmgr_info' call a >>> 'load_external_function' with execution of sequence sea

Re: [HACKERS] Patch for fixing a few memory leaks

2001-10-05 Thread Teodor Sigaev
>>Tom, I want to notice that initGISTstate is called for every inserting >>value (for each row). I think it's not good, because this function >>called 'fmgr_info' 7 times. 'fmgr_info' call a >>'load_external_function' with execution of sequence search on library >>name. Any suggestion? >> > > fmg

Re: [HACKERS] Patch for fixing a few memory leaks

2001-10-04 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Is there some sort of a system behind which places are subject to leaks > and which places are just too lazy to call pfree()? > I know that index support procedures must not leak, hmm, I guess this > would include the function manager... Yeah, that'

Re: [HACKERS] Patch for fixing a few memory leaks

2001-10-04 Thread Peter Eisentraut
Tom Lane writes: > Applied, thanks. (Looks like the leaks were introduced fairly > recently by the dynamic-search-path feature.) Is there some sort of a system behind which places are subject to leaks and which places are just too lazy to call pfree()? I know that index support procedures must

Re: [HACKERS] Patch for fixing a few memory leaks

2001-10-04 Thread Tom Lane
Teodor Sigaev <[EMAIL PROTECTED]> writes: > Patch fix memory leaks in src/backend/utils/fmgr/dfmgr.c . Applied, thanks. (Looks like the leaks were introduced fairly recently by the dynamic-search-path feature.) > Tom, I want to notice that initGISTstate is called for every inserting > value (fo

Re: [HACKERS] Patch for fixing a few memory leaks

2001-10-04 Thread Bruce Momjian
Patch applied. Thanks. > Patch fix memory leaks in src/backend/utils/fmgr/dfmgr.c . > This leaks is very significant with massive update/insert tables with gist > indexes in one transaction or with following sequence of commands: > 1. COPY in table large number of row > 2. CREATE GiST index on

[HACKERS] Patch for fixing a few memory leaks

2001-10-04 Thread Teodor Sigaev
Patch fix memory leaks in src/backend/utils/fmgr/dfmgr.c . This leaks is very significant with massive update/insert tables with gist indexes in one transaction or with following sequence of commands: 1. COPY in table large number of row 2. CREATE GiST index on table 3. VACUUM ANALYZE On third st