Re: [HACKERS] Patch: add psql tab completion for event triggers

2014-04-14 Thread Michael Paquier
On Mon, Apr 14, 2014 at 9:46 PM, Robert Haas wrote: > On Wed, Apr 9, 2014 at 8:58 PM, Ian Barwick wrote: >> Apologies again, that was ill-thought out. Revised patch attached with only >> the additions related to event triggers, and the small fix for ALTER TRIGGER >> mentioned above which ensures

Re: [HACKERS] Patch: add psql tab completion for event triggers

2014-04-14 Thread Robert Haas
On Wed, Apr 9, 2014 at 8:58 PM, Ian Barwick wrote: > Apologies again, that was ill-thought out. Revised patch attached with only > the additions related to event triggers, and the small fix for ALTER TRIGGER > mentioned above which ensures "RENAME TO" is applied only when "ALTER > TRIGGER ON " wa

Re: [HACKERS] Patch: add psql tab completion for event triggers

2014-04-09 Thread Ian Barwick
On 10/04/14 00:23, Robert Haas wrote: On Tue, Apr 8, 2014 at 5:27 AM, Ian Barwick wrote: On 08/04/14 18:22, Ian Barwick wrote: As it was kind of annoying not to have this when playing around with event triggers. This also tightens up the existing tab completion for ALTER TRIGGER, which conta

Re: [HACKERS] Patch: add psql tab completion for event triggers

2014-04-09 Thread Robert Haas
On Tue, Apr 8, 2014 at 5:27 AM, Ian Barwick wrote: > On 08/04/14 18:22, Ian Barwick wrote: >> >> As it was kind of annoying not to have this when playing around with >> event triggers. >> >> This also tightens up the existing tab completion for ALTER TRIGGER, >> which contained redundant code for

Re: [HACKERS] Patch: add psql tab completion for event triggers

2014-04-08 Thread Ian Barwick
On 08/04/14 18:22, Ian Barwick wrote: As it was kind of annoying not to have this when playing around with event triggers. This also tightens up the existing tab completion for ALTER TRIGGER, which contained redundant code for table name completion, and which was also causing a spurious "RENAME

[HACKERS] Patch: add psql tab completion for event triggers

2014-04-08 Thread Ian Barwick
As it was kind of annoying not to have this when playing around with event triggers. This also tightens up the existing tab completion for ALTER TRIGGER, which contained redundant code for table name completion, and which was also causing a spurious "RENAME TO" to be inserted in this context: