On Wed, Feb 22, 2017 at 12:25 PM, Robert Haas wrote:
> Looks fine to me. Committed. I did move es_queryText to what I think
> is a more appropriate location in the structure definition.
>
> Thanks.
>
Many thanks to Robert for committing and to Kuntal and Amit for reviewing.
--
Regards,
Rafia S
On Tue, Feb 21, 2017 at 9:18 AM, Rafia Sabih
wrote:
> Done.
Looks fine to me. Committed. I did move es_queryText to what I think
is a more appropriate location in the structure definition.
Thanks.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
On Mon, Feb 20, 2017 at 8:35 PM, Kuntal Ghosh
wrote:
>
> + char *query_data;
> + query_data = estate->es_sourceText;
> estate->es_sourceText is a const char* variable. Assigning this const
> pointer to a non-const pointer violates the rules
> constant-correctness. So, either you should c
On Mon, Feb 20, 2017 at 10:11 AM, Rafia Sabih
wrote:
> On Sun, Feb 19, 2017 at 10:11 PM, Robert Haas wrote:
>> + query_data = (char *) palloc0(strlen(estate->es_queryString) + 1);
>> + strcpy(query_data, estate->es_queryString);
>>
>> It's unnecessary to copy the query string here; yo
On Sun, Feb 19, 2017 at 10:11 PM, Robert Haas wrote:
> On Thu, Feb 16, 2017 at 6:41 PM, Kuntal Ghosh
> wrote:
> > On Thu, Feb 16, 2017 at 5:47 PM, Rafia Sabih
> > wrote:
> >> Other that that I updated some comments and other cleanup things. Please
> >> find the attached patch for the revised ve
On Thu, Feb 16, 2017 at 6:41 PM, Kuntal Ghosh
wrote:
> On Thu, Feb 16, 2017 at 5:47 PM, Rafia Sabih
> wrote:
>> Other that that I updated some comments and other cleanup things. Please
>> find the attached patch for the revised version.
> Looks good.
>
> It has passed the regression tests (with a
On Thu, Feb 16, 2017 at 5:47 PM, Rafia Sabih
wrote:
> Other that that I updated some comments and other cleanup things. Please
> find the attached patch for the revised version.
Looks good.
It has passed the regression tests (with and without regress mode).
Query is getting displayed for parallel
On Thu, Feb 16, 2017 at 5:06 PM, Kuntal Ghosh
wrote:
>
> >>
> >> Another question is don't we need to set debug_query_string in worker?
> >
> > In the updated version I am setting it in ParallelQueryMain.
> >
> Ahh, I missed that. debug_query_string is used to show the log
> statements. Hence, it
On Sat, Feb 11, 2017 at 8:38 AM, Rafia Sabih
wrote:
>
>>
>> Another question is don't we need to set debug_query_string in worker?
>
> In the updated version I am setting it in ParallelQueryMain.
>
Ahh, I missed that. debug_query_string is used to show the log
statements. Hence, it should be set.
> >
> > There are some spacing issues in the code. For example,
> > + estate->es_queryString = (char
> > *)palloc0(strlen(queryDesc->sourceText) + 1);
> > + /*Estimate space for query text. */
> > pgindent might be helpful to track all such changes.
> >
>
Fixed.
> > +#define PARALLEL_
On Fri, Feb 10, 2017 at 2:54 PM, Kuntal Ghosh
wrote:
> On Tue, Feb 7, 2017 at 10:19 AM, Rafia Sabih
> wrote:
>> Thanks a lot Kuntal for the review, please find attached patch for the
>> revised version.
> Few comments on the patch:
>
> There are some spacing issues in the code. For example,
> +
On Tue, Feb 7, 2017 at 10:19 AM, Rafia Sabih
wrote:
> Thanks a lot Kuntal for the review, please find attached patch for the
> revised version.
Few comments on the patch:
There are some spacing issues in the code. For example,
+ estate->es_queryString = (char
*)palloc0(strlen(queryDesc->sou
On Mon, Jan 23, 2017 at 2:46 PM, Kuntal Ghosh
wrote:
> I've looked into the patch. I've some comments regarding that.
>
> +#define PARALLEL_KEY_QUERY_TEXTUINT64CONST(0xE010)
> It should be UINT64CONST(0xE00A)
>
> + query_len = strlen(query_data) + 1;
> +
On Fri, Jan 13, 2017 at 4:25 PM, Rafia Sabih
wrote:
>
> Please let me know your feedback over the same.
>
I've looked into the patch. I've some comments regarding that.
+#define PARALLEL_KEY_QUERY_TEXTUINT64CONST(0xE010)
It should be UINT64CONST(0xE00A)
+ qu
On Thu, Jan 12, 2017 at 6:24 PM, Robert Haas wrote:
> On Wed, Jan 11, 2017 at 11:12 PM, Tom Lane wrote:
>> Robert Haas writes:
>>> On Wed, Jan 11, 2017 at 6:36 PM, Tom Lane wrote:
That would work, if you had a way to get at the active QueryDesc ...
but we don't pass that down to execu
On Wed, Jan 11, 2017 at 11:12 PM, Tom Lane wrote:
> Robert Haas writes:
>> On Wed, Jan 11, 2017 at 6:36 PM, Tom Lane wrote:
>>> That would work, if you had a way to get at the active QueryDesc ...
>>> but we don't pass that down to executor nodes.
>
>> Hmm, that is a bit of a problem. Do you ha
Robert Haas writes:
> On Wed, Jan 11, 2017 at 6:36 PM, Tom Lane wrote:
>> That would work, if you had a way to get at the active QueryDesc ...
>> but we don't pass that down to executor nodes.
> Hmm, that is a bit of a problem. Do you have a suggestion?
Copy that string pointer into the EState
On Wed, Jan 11, 2017 at 6:36 PM, Tom Lane wrote:
> Robert Haas writes:
>> On Wed, Jan 11, 2017 at 7:37 AM, Tom Lane wrote:
>>> As far as reproducing the pg_stat_activity query goes, you could probably
>>> grab that string out of the master backend's pgstat entry and pass it over
>>> at parallel
Robert Haas writes:
> On Wed, Jan 11, 2017 at 7:37 AM, Tom Lane wrote:
>> As far as reproducing the pg_stat_activity query goes, you could probably
>> grab that string out of the master backend's pgstat entry and pass it over
>> at parallel query start. But please don't confuse it with either
>>
On Wed, Jan 11, 2017 at 7:37 AM, Tom Lane wrote:
> Rafia Sabih writes:
>> Approach:
>> A token for query string is created in the shared memory, this token is
>> populated with the query string using the global string --
>> debug_query_string. Now, for each of the worker when
>> ExecGetParallelQu
Rafia Sabih writes:
> Approach:
> A token for query string is created in the shared memory, this token is
> populated with the query string using the global string --
> debug_query_string. Now, for each of the worker when
> ExecGetParallelQueryDesc is called, we retrieve the query text from shared
Hello everybody,
Currently, query string is not passed to the workers and only master has
it. In the events, when multiple queries are running on a server and for
one query some worker crashes then it becomes quite burdensome to find the
query with the crashed worker, since on the worker crash no
22 matches
Mail list logo
