Re: [HACKERS] Package namespace and Safe init cleanup for plperl UPDATE 3 [PATCH]

2010-02-02 Thread Tim Bunce
On Mon, Feb 01, 2010 at 07:53:05PM -0700, Alex Hunsaker wrote: > On Mon, Feb 1, 2010 at 03:58, Tim Bunce wrote: > > On Sat, Jan 30, 2010 at 06:38:59PM -0700, Alex Hunsaker wrote: > > > >> plc_safe_ok.pl seems to loose its CVS $PostgreSQL$ keyword. > >Probably a slip-up when I merged the changes fr

Re: [HACKERS] Package namespace and Safe init cleanup for plperl UPDATE 3 [PATCH]

2010-02-01 Thread Alex Hunsaker
On Mon, Feb 1, 2010 at 03:58, Tim Bunce wrote: > On Sat, Jan 30, 2010 at 06:38:59PM -0700, Alex Hunsaker wrote: > >> plc_safe_ok.pl seems to loose its CVS $PostgreSQL$ keyword. >Probably a slip-up when I merged the changes from HEAD up through my >chain of branches. Can you send an updated patch?

Re: [HACKERS] Package namespace and Safe init cleanup for plperl UPDATE 3 [PATCH]

2010-02-01 Thread Tim Bunce
On Mon, Feb 01, 2010 at 10:46:10AM -0500, Robert Haas wrote: > On Mon, Feb 1, 2010 at 5:58 AM, Tim Bunce wrote: > > p.s. If there is interest in defining a documented API (for DBAs to > > control what gets loaded into Safe and shared with it) for *9.0* > > then that could be worked on, once this p

Re: [HACKERS] Package namespace and Safe init cleanup for plperl UPDATE 3 [PATCH]

2010-02-01 Thread Robert Haas
On Mon, Feb 1, 2010 at 5:58 AM, Tim Bunce wrote: > p.s. If there is interest in defining a documented API (for DBAs to > control what gets loaded into Safe and shared with it) for *9.0* > then that could be worked on, once this pach is in, ready for the > next commitfest. This is the last CommitF

Re: [HACKERS] Package namespace and Safe init cleanup for plperl UPDATE 3 [PATCH]

2010-02-01 Thread Tim Bunce
On Sat, Jan 30, 2010 at 06:38:59PM -0700, Alex Hunsaker wrote: > On Sat, Jan 30, 2010 at 16:16, Tim Bunce wrote: > > This is an update to the final plperl patch in the series from me. > > > > Changes in the original patch: > > plc_safe_ok.pl seems to loose its CVS $PostgreSQL$ keyword. Probably

Re: [HACKERS] Package namespace and Safe init cleanup for plperl UPDATE 3 [PATCH]

2010-01-30 Thread Alex Hunsaker
On Sat, Jan 30, 2010 at 16:16, Tim Bunce wrote: > This is an update to the final plperl patch in the series from me. > > Changes in the original patch: plc_safe_ok.pl seems to loose its CVS $PostgreSQL$ keyword. > - Ensure Safe container opmask is restored even if @EvalInSafe code >  throws an e

[HACKERS] Package namespace and Safe init cleanup for plperl UPDATE 3 [PATCH]

2010-01-30 Thread Tim Bunce
This is an update to the final plperl patch in the series from me. Changes in the original patch: - Moved internal functions out of main:: namespace into PostgreSQL::InServer and PostgreSQL::InServer::safe - Restructured Safe compartment setup code to generalize and separate the data fro