Re: [HACKERS] PL/Perl: spi_prepare() and RETURNING

2006-08-27 Thread Jonah H. Harris
On 8/27/06, Tom Lane <[EMAIL PROTECTED]> wrote: I've applied a patch along these lines. David's plperl example now does what (I think) he expected. Kewl. Thanks Tom. -- Jonah H. Harris, Software Architect | phone: 732.331.1300 EnterpriseDB Corporation| fax: 732.331.1301 33 Wood

Re: [HACKERS] PL/Perl: spi_prepare() and RETURNING

2006-08-27 Thread Tom Lane
"Jonah H. Harris" <[EMAIL PROTECTED]> writes: > On 8/24/06, Tom Lane <[EMAIL PROTECTED]> wrote: >> This reminds me of a consideration I had been intending to bring up on >> the mailing lists: what exactly do we want to do with the SPI API for >> RETURNING queries? > I like adding RETURNING-specifi

Re: [HACKERS] PL/Perl: spi_prepare() and RETURNING

2006-08-24 Thread Jonah H. Harris
On 8/24/06, Tom Lane <[EMAIL PROTECTED]> wrote: This reminds me of a consideration I had been intending to bring up on the mailing lists: what exactly do we want to do with the SPI API for RETURNING queries? The current behavior is that it still returns SPI_OK_INSERT and so on, but also creates

Re: [HACKERS] PL/Perl: spi_prepare() and RETURNING

2006-08-24 Thread Andrew Dunstan
Tom Lane wrote: Another issue I noted in that same area is that spi.c does not set SPI_processed for a utility statement, even if the utility statement returns tuples. Is this a bug, or should we leave it alone? Bug or not, it's at least a limitation we could do without, I think. cheers

Re: [HACKERS] PL/Perl: spi_prepare() and RETURNING

2006-08-24 Thread Tom Lane
David Fetter <[EMAIL PROTECTED]> writes: >> I've found a little lacuna in the RETURNING feature, that being in >> PL/Perl's spi_prepare()/spi_execute_prepared() as illustrated in the >> attached file on CVS TIP. It looks like plperl_spi_execute_fetch_result only expects to find tuples returned if

Re: [HACKERS] PL/Perl: spi_prepare() and RETURNING

2006-08-24 Thread Andrew Dunstan
David Fetter wrote: On Thu, Aug 24, 2006 at 11:31:02AM -0700, David Fetter wrote: Folks, I've found a little lacuna in the RETURNING feature, that being in PL/Perl's spi_prepare()/spi_execute_prepared() as illustrated in the attached file on CVS TIP. I think that fixing this is a matter of

Re: [HACKERS] PL/Perl: spi_prepare() and RETURNING

2006-08-24 Thread David Fetter
On Thu, Aug 24, 2006 at 11:31:02AM -0700, David Fetter wrote: > Folks, > > I've found a little lacuna in the RETURNING feature, that being in > PL/Perl's spi_prepare()/spi_execute_prepared() as illustrated in the > attached file on CVS TIP. > > I think that fixing this is a matter of post-RETURNI

[HACKERS] PL/Perl: spi_prepare() and RETURNING

2006-08-24 Thread David Fetter
Folks, I've found a little lacuna in the RETURNING feature, that being in PL/Perl's spi_prepare()/spi_execute_prepared() as illustrated in the attached file on CVS TIP. I think that fixing this is a matter of post-RETURNING-patch cleanup. What else might not know about RETURNING that needs to? C