Re: [HACKERS] PATCH: tracking temp files in pg_stat_database

2012-01-26 Thread Tomas Vondra
On 26 Leden 2012, 14:44, Magnus Hagander wrote: > On Sat, Jan 21, 2012 at 20:12, Tomas Vondra wrote: >> On 21 Leden 2012, 18:13, Magnus Hagander wrote: >>> On Sat, Jan 21, 2012 at 18:02, Tomas Vondra wrote: >>> Though I just looked at the tabstat code again, and we already split >>> that message

Re: [HACKERS] PATCH: tracking temp files in pg_stat_database

2012-01-26 Thread Magnus Hagander
On Sat, Jan 21, 2012 at 20:12, Tomas Vondra wrote: > On 21 Leden 2012, 18:13, Magnus Hagander wrote: >> On Sat, Jan 21, 2012 at 18:02, Tomas Vondra wrote: >> Though I just looked at the tabstat code again, and we already split >> that message up at regular intervals. Which would make it quite wei

Re: [HACKERS] PATCH: tracking temp files in pg_stat_database

2012-01-21 Thread Tomas Vondra
On 21 Leden 2012, 18:13, Magnus Hagander wrote: > On Sat, Jan 21, 2012 at 18:02, Tomas Vondra wrote: >> On 20 Leden 2012, 13:23, Magnus Hagander wrote: >>> I'm wondering if this (and also my deadlocks stats patch that's int he >>> queue) should instead of inventing new pgstats messages, add fields

Re: [HACKERS] PATCH: tracking temp files in pg_stat_database

2012-01-21 Thread Magnus Hagander
On Sat, Jan 21, 2012 at 18:02, Tomas Vondra wrote: > On 20 Leden 2012, 13:23, Magnus Hagander wrote: >> On Tue, Jan 17, 2012 at 21:39, Tomas Vondra wrote: >>> On 20.12.2011 19:59, Tomas Vondra wrote: On 20.12.2011 11:20, Magnus Hagander wrote: > 2011/12/20 Tomas Vondra : >> >> I

Re: [HACKERS] PATCH: tracking temp files in pg_stat_database

2012-01-21 Thread Tomas Vondra
On 20 Leden 2012, 13:23, Magnus Hagander wrote: > On Tue, Jan 17, 2012 at 21:39, Tomas Vondra wrote: >> On 20.12.2011 19:59, Tomas Vondra wrote: >>> On 20.12.2011 11:20, Magnus Hagander wrote: 2011/12/20 Tomas Vondra : > > I haven't updated the docs yet - let's see if the patch is acc

Re: [HACKERS] PATCH: tracking temp files in pg_stat_database

2012-01-20 Thread Magnus Hagander
On Tue, Jan 17, 2012 at 21:39, Tomas Vondra wrote: > On 20.12.2011 19:59, Tomas Vondra wrote: >> On 20.12.2011 11:20, Magnus Hagander wrote: >>> 2011/12/20 Tomas Vondra : I haven't updated the docs yet - let's see if the patch is acceptable at all first. >>> >>> Again, without havin

Re: [HACKERS] PATCH: tracking temp files in pg_stat_database

2012-01-17 Thread Tomas Vondra
On 20.12.2011 19:59, Tomas Vondra wrote: > On 20.12.2011 11:20, Magnus Hagander wrote: >> 2011/12/20 Tomas Vondra : >>> >>> I haven't updated the docs yet - let's see if the patch is acceptable at >>> all first. >> >> Again, without having reviewed the code, this looks like a feature >> we'd want,

Re: [HACKERS] PATCH: tracking temp files in pg_stat_database

2011-12-20 Thread Tomas Vondra
On 20.12.2011 11:20, Magnus Hagander wrote: > 2011/12/20 Tomas Vondra : >> >> I haven't updated the docs yet - let's see if the patch is acceptable at >> all first. > > Again, without having reviewed the code, this looks like a feature > we'd want, so please add some docs, and then submit it for t

Re: [HACKERS] PATCH: tracking temp files in pg_stat_database

2011-12-20 Thread Magnus Hagander
On Tue, Dec 20, 2011 at 11:45, Tomas Vondra wrote: > On 20 Prosinec 2011, 11:20, Magnus Hagander wrote: >> 2011/12/20 Tomas Vondra : >>> >>> I haven't updated the docs yet - let's see if the patch is acceptable at >>> all first. >> >> Again, without having reviewed the code, this looks like a feat

Re: [HACKERS] PATCH: tracking temp files in pg_stat_database

2011-12-20 Thread Tomas Vondra
On 20 Prosinec 2011, 11:20, Magnus Hagander wrote: > 2011/12/20 Tomas Vondra : >> >> I haven't updated the docs yet - let's see if the patch is acceptable at >> all first. > > Again, without having reviewed the code, this looks like a feature > we'd want, so please add some docs, and then submit it

Re: [HACKERS] PATCH: tracking temp files in pg_stat_database

2011-12-20 Thread Magnus Hagander
2011/12/20 Tomas Vondra : > Hello everybody, > > this patch adds two counters to pg_stat_database to track temporary > files - number of temp files and number of bytes. I see this as a useful > feature, as temporary files often cause a lot of IO (because of low > work_mem etc.). The log_temp_files

[HACKERS] PATCH: tracking temp files in pg_stat_database

2011-12-19 Thread Tomas Vondra
Hello everybody, this patch adds two counters to pg_stat_database to track temporary files - number of temp files and number of bytes. I see this as a useful feature, as temporary files often cause a lot of IO (because of low work_mem etc.). The log_temp_files is useful, but you have to parse the