Re: [HACKERS] PATCH: Don't downcase filepath/filename while loading libraries

2017-06-20 Thread Tom Lane
QL Zhuo writes: > And, the attached new patch fixes the memory leaks. Pushed with minor adjustments --- mostly, getting rid of the now-redundant canonicalize_path() call. I also updated the documentation. I notice the documentation formerly said "All library names are converted to lower case un

Re: [HACKERS] PATCH: Don't downcase filepath/filename while loading libraries

2017-06-15 Thread QL Zhuo
"That's fourteen years without complains", so maybe not to back-patch is good choice, until someone complains this :) And, the attached new patch fixes the memory leaks. -- This email address (zhuo.devgmail.com) is only for development affairs, e.g. mail list, please mail to zhuohexoasis.com or z

[HACKERS] PATCH: Don't downcase filepath/filename while loading libraries

2017-06-15 Thread David G. Johnston
On Thursday, June 15, 2017, Tom Lane wrote: > Michael Paquier writes: > > On Fri, Jun 16, 2017 at 1:01 PM, Tom Lane wrote: > >> (2) My inclination would be not to back-patch. This change could break > >> configurations that worked before, and the lack of prior complaints > >> says that not man

Re: [HACKERS] PATCH: Don't downcase filepath/filename while loading libraries

2017-06-15 Thread Tom Lane
Michael Paquier writes: > On Fri, Jun 16, 2017 at 1:01 PM, Tom Lane wrote: >> (2) My inclination would be not to back-patch. This change could break >> configurations that worked before, and the lack of prior complaints >> says that not many people are having a problem with it. > That's fourtee

Re: [HACKERS] PATCH: Don't downcase filepath/filename while loading libraries

2017-06-15 Thread Michael Paquier
On Fri, Jun 16, 2017 at 1:01 PM, Tom Lane wrote: > (2) My inclination would be not to back-patch. This change could break > configurations that worked before, and the lack of prior complaints > says that not many people are having a problem with it. That's fourteen years without complains, still

Re: [HACKERS] PATCH: Don't downcase filepath/filename while loading libraries

2017-06-15 Thread Tom Lane
Michael Paquier writes: > On Fri, Jun 16, 2017 at 11:04 AM, QL Zhuo wrote: >> After few digging, I found there's a wrong use of `SplitIdentifierString` in >> function `load_libraries` in /src/backend/utils/init/miscinit.c, and the >> attached patch fixes it. > That's a good catch. All the other

Re: [HACKERS] PATCH: Don't downcase filepath/filename while loading libraries

2017-06-15 Thread Michael Paquier
On Fri, Jun 16, 2017 at 11:04 AM, QL Zhuo wrote: > I just put this line in my postgresql.conf: > > ``` > shared_preload_libraries = '/Path/Contains/UpCaseWords/an_ext.so' > ``` > > Then the server couldn't start. It tried to load the file > "/path/contains/upcasewords/an_ext.so" and failed. > > Af

[HACKERS] PATCH: Don't downcase filepath/filename while loading libraries

2017-06-15 Thread QL Zhuo
I just put this line in my postgresql.conf: ``` shared_preload_libraries = '/Path/Contains/UpCaseWords/an_ext.so' ``` Then the server couldn't start. It tried to load the file "/path/contains/upcasewords/an_ext.so" and failed. After few digging, I found there's a wrong use of `SplitIdentifierStr