Re: [HACKERS] OpenFile() Permissions Refactor

2017-09-24 Thread David Steele
On 9/23/17 10:22 AM, Peter Eisentraut wrote: > On 9/13/17 10:26, David Steele wrote: >> Here's a new patch based on your review. Where I had a question I made >> a choice as described below: > > I have committed the changes to the file APIs and a fix for the umask > save/restore issue. Thank you

Re: [HACKERS] OpenFile() Permissions Refactor

2017-09-23 Thread Peter Eisentraut
On 9/13/17 10:26, David Steele wrote: > Here's a new patch based on your review. Where I had a question I made > a choice as described below: I have committed the changes to the file APIs and a fix for the umask save/restore issue. The mkdir changes didn't really inspire me. Replacing mkdir() w

Re: [HACKERS] OpenFile() Permissions Refactor

2017-09-13 Thread David Steele
Hi Peter, Here's a new patch based on your review. Where I had a question I made a choice as described below: On 9/1/17 1:58 PM, David Steele wrote: > On 9/1/17 1:15 PM, Peter Eisentraut wrote: >> On 8/29/17 12:15, David Steele wrote: >> >> I wonder whether we even need that much flexibility. W

Re: [HACKERS] OpenFile() Permissions Refactor

2017-09-01 Thread David Steele
On 9/1/17 1:15 PM, Peter Eisentraut wrote: > On 8/29/17 12:15, David Steele wrote: > > I wonder whether we even need that much flexibility. We already set a > global umask, so we could just open all files with 0666 and let the > umask sort it out. Then we don't need all the *Perm() variants. We

Re: [HACKERS] OpenFile() Permissions Refactor

2017-09-01 Thread Tom Lane
Peter Eisentraut writes: > I wonder whether we even need that much flexibility. We already set a > global umask, so we could just open all files with 0666 and let the > umask sort it out. Then we don't need all the *Perm() variants. -1. What that would mean is that if somebody had a need for a

Re: [HACKERS] OpenFile() Permissions Refactor

2017-09-01 Thread Peter Eisentraut
On 8/29/17 12:15, David Steele wrote: > While working on the patch to allow group reads of $PGDATA I refactored > the various OpenFile() functions to use default/global permissions > rather than permissions defined in each call. > > I think the patch stands on its own regardless of whether we acce

[HACKERS] OpenFile() Permissions Refactor

2017-08-29 Thread David Steele
Hackers, While working on the patch to allow group reads of $PGDATA I refactored the various OpenFile() functions to use default/global permissions rather than permissions defined in each call. I think the patch stands on its own regardless of whether we accept the patch to allow group permission