Re: [HACKERS] Notification when freespaces empty

2005-05-24 Thread ITAGAKI Takahiro
Simon Riggs <[EMAIL PROTECTED]> wrote: > > Furthermore, this patch detaches empty fsmpages then. > Does that do anything useful though? > I thought we don't reallocate until VACUUM time, whereupon we identify > any empty slots and reuse them. Who cares whether we deallocate earlier? Yes, we canno

Re: [HACKERS] Notification when freespaces empty

2005-05-20 Thread Tom Lane
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > I think that this patch is useful to decide when to vacuum. > It notifies when freespace empties as follows: No, it doesn't complain that there is no freespace, it complains when a specific request can't be fulfilled; which for a large request might n

Re: [HACKERS] Notification when freespaces empty

2005-05-20 Thread Simon Riggs
On Fri, 2005-05-20 at 14:41 +0900, ITAGAKI Takahiro wrote: > LOG: FreeSpace for "public.accounts" becomes empty. (stored=1, avg=159, > min=128) Looks useful to me, until we patch up FSMs more fully in the future. Might need rewording. Stored -> stored pages, Avg -> Avg Row Length. Probably shou

[HACKERS] Notification when freespaces empty

2005-05-19 Thread ITAGAKI Takahiro
Hello all, I think that this patch is useful to decide when to vacuum. It notifies when freespace empties as follows: $ ./pgbench -i $ ./pgbench -n -t 1000 LOG: FreeSpace for "public.accounts" becomes empty. (stored=1, avg=159, min=128) LOG: FreeSpace for "public.tellers" becomes empty. (store