Re: [HACKERS] Non-volatile variables used for spinlock manipulation

2015-09-04 Thread Andres Freund
On 2015-09-04 09:42:20 -0400, Tom Lane wrote: > Antonin Houska writes: > > Since SpinLockAcquire() / SpinLockRelease() macros usually reference > > variables > > declared as volatile, I wonder if the following changes should be applied. > > We've been making changes to remove that requirement, s

Re: [HACKERS] Non-volatile variables used for spinlock manipulation

2015-09-04 Thread Tom Lane
Antonin Houska writes: > Since SpinLockAcquire() / SpinLockRelease() macros usually reference variables > declared as volatile, I wonder if the following changes should be applied. We've been making changes to remove that requirement, so I think that at least in 9.5/HEAD this isn't an issue anymo

[HACKERS] Non-volatile variables used for spinlock manipulation

2015-09-04 Thread Antonin Houska
Since SpinLockAcquire() / SpinLockRelease() macros usually reference variables declared as volatile, I wonder if the following changes should be applied. -- Antonin Houska Cybertec Schönig & Schönig GmbH Gröhrmühlgasse 26 A-2700 Wiener Neustadt Web: http://www.postgresql-support.de, http://www.cy