Re: [HACKERS] NoMovementScanDirection in heapgettup() and heapgettup_pagemode()

2017-08-28 Thread Mithun Cy
On Mon, Aug 28, 2017 at 5:50 PM, Tom Lane wrote: > I think that's probably dead code given that ExecutorRun short-circuits > everything for NoMovementScanDirection. There is some use of > NoMovementScanDirection for indexscans, to denote an unordered index, > but likely that could be got rid of t

Re: [HACKERS] NoMovementScanDirection in heapgettup() and heapgettup_pagemode()

2017-08-28 Thread Tom Lane
Mithun Cy writes: > I was trying to study NoMovementScanDirection part of heapgettup() and > heapgettup_pagemode(). If I am right there is no test in test suit to > hit this code. I did run make check-world could not hit it. Also, > coverage report in > https://coverage.postgresql.org/src/backend/

[HACKERS] NoMovementScanDirection in heapgettup() and heapgettup_pagemode()

2017-08-27 Thread Mithun Cy
Hi all, I was trying to study NoMovementScanDirection part of heapgettup() and heapgettup_pagemode(). If I am right there is no test in test suit to hit this code. I did run make check-world could not hit it. Also, coverage report in https://coverage.postgresql.org/src/backend/access/heap/heapam.c.