On Mon, Aug 28, 2017 at 5:50 PM, Tom Lane wrote:
> I think that's probably dead code given that ExecutorRun short-circuits
> everything for NoMovementScanDirection. There is some use of
> NoMovementScanDirection for indexscans, to denote an unordered index,
> but likely that could be got rid of t
Mithun Cy writes:
> I was trying to study NoMovementScanDirection part of heapgettup() and
> heapgettup_pagemode(). If I am right there is no test in test suit to
> hit this code. I did run make check-world could not hit it. Also,
> coverage report in
> https://coverage.postgresql.org/src/backend/
Hi all,
I was trying to study NoMovementScanDirection part of heapgettup() and
heapgettup_pagemode(). If I am right there is no test in test suit to
hit this code. I did run make check-world could not hit it. Also,
coverage report in
https://coverage.postgresql.org/src/backend/access/heap/heapam.c.
Tom Lane wrote:
Neil Conway <[EMAIL PROTECTED]> writes:
Ah, okay. I'll remove gistscancache() then, as this seems to be dead
code.
Is there someone out there that can instrument the code with Rational
Coverage in order to see how much dead code is still there ? Or at least
see how much code is use
Neil Conway <[EMAIL PROTECTED]> writes:
> Ah, okay. I'll remove gistscancache() then, as this seems to be dead
> code.
Certainly none of the other index types have a concept of caching the
previous tuple like that. I agree, zap it.
regards, tom lane
-
Neil Conway <[EMAIL PROTECTED]> writes:
> In the context of an index scan, what does NoMovementScanDirection
> indicate?
ScanDirection is used in different ways in different places. The
planner uses NoMovementScanDirection to denote an unordered index scan,
and this propagates into the indxorderd
On Mon, 2004-11-08 at 13:56, Tom Lane wrote:
> However execMain.c uses NoMovementScanDirection to denote "do nothing",
> and so es_direction will never have this value at runtime.
Ah, okay. I'll remove gistscancache() then, as this seems to be dead
code.
> Not sure if it's worth factoring the enu
In the context of an index scan, what does NoMovementScanDirection
indicate? On the one hand, relation.h comments:
* 'indexscandir' is one of:
*ForwardScanDirection: forward scan of an ordered index
*BackwardScanDirection: backward scan of an ordered index
*NoMovementScanDirection:
