ITAGAKI Takahiro <[EMAIL PROTECTED]> writes:
> - NDirectFile{Read|Write} are renamed to BufFile{Read|Write}Count.
> - They are still declared in execdebug.h and buffile.c includes it.
After some thought I concluded that the least ugly way to do this
was to declare and define the variables in the s
Tom Lane wrote:
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes:
BTW, we have the word 'Direct' in ShowBufferUsage().
Can I keep it as-is?
ShowBufferUsage()
! Shared blocks: ...
! Local blocks: ...
! Direct blocks: read, written
Good point. Seems like it should be changed, but I am no
Here is a revised patch to renewal NDirectFileRead/Write.
> Tom Lane <[EMAIL PROTECTED]> wrote:
> > * Let's rename them BufFileReadCount and BufFileWriteCount to reflect
> > their actual purpose.
> > * In any case I agree that the current arrangement
> > with execdebug.h declaring variables define
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes:
> BTW, we have the word 'Direct' in ShowBufferUsage().
> Can I keep it as-is?
> ShowBufferUsage()
> ! Shared blocks: ...
> ! Local blocks: ...
> ! Direct blocks: read, written
Good point. Seems like it should be changed, but I am not sure to
Tom Lane <[EMAIL PROTECTED]> wrote:
> * Let's rename them BufFileReadCount and BufFileWriteCount to reflect
> their actual purpose.
It looks good. No one uses NDirectFileRead/Write variables now,
so we can rename it freely.
BTW, we have the word 'Direct' in ShowBufferUsage().
Can I keep it as-i
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes:
> Here is a patch to user NDirectFileRead/Write counters to get I/O counts
> in BufFile module. We can see the counters when log_statement_stats is on.
Couple thoughts here:
* Let's rename them BufFileReadCount and BufFileWriteCount to reflect
their ac
"Hitoshi Harada" <[EMAIL PROTECTED]> wrote:
> so I guess all of these variables should be defined together but
> actually you put the two in buffile.h while the others in
> buf_internals.h. Is there clear reason for that?
That's because buffile.c includes buffile.h, but not buf_internals.h .
NDi
2008/8/5 ITAGAKI Takahiro <[EMAIL PROTECTED]>:
> Here is a patch to user NDirectFileRead/Write counters to get I/O counts
> in BufFile module. We can see the counters when log_statement_stats is on.
>
> The information is different from trace_sort; trace_sort shows used blocks
> in external sort, a
Here is a patch to user NDirectFileRead/Write counters to get I/O counts
in BufFile module. We can see the counters when log_statement_stats is on.
The information is different from trace_sort; trace_sort shows used blocks
in external sort, and log_statement_stats shows how many I/Os are submitted
Hello,
I'd like to use NDirectFileRead and NDirectFileWrite statistics counters
for counting reads and writes in BufFile. They are defined, but not used
now. BufFile is used for tuple sorting or materializing, so we could use
NDirectFileRead/Write to retrieve how many I/Os are done in temp tablesp
10 matches
Mail list logo
