Re: [HACKERS] More pgindent follies

2001-05-23 Thread Tom Lane
[EMAIL PROTECTED] (Nathan Myers) writes: > This is good news! > Maybe this process can be formalized. That is, each official release > migh contain a source file with various "modern" constructs which we > suspect might break old compilers. I have no objection to this, if the process *is* for

Re: [HACKERS] More pgindent follies

2001-05-23 Thread Nathan Myers
On Wed, May 23, 2001 at 11:58:51AM -0400, Bruce Momjian wrote: > > > I don't see the problem here. My assumption is that the comment is not > > > part of the define, right? > > > > Well, that's the question. ANSI C requires comments to be replaced by > > whitespace before preprocessor commands

Re: [HACKERS] More pgindent follies

2001-05-23 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I agree, but in a certain sense, we would have found those compilers > already. This is not new behavour as far as I know, and clearly this > would throw a compiler error. [ Digs around ... ] OK, you're right, it's not new behavior; we have instances

Re: [HACKERS] More pgindent follies

2001-05-23 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: >> 4. This breaking of a comment attached to a #define scares me. >> >> *** >> *** 1691,1705 >> >> #define FIXED_CHAR_SEL 0.04/* about 1/25 */ >> #define CHAR_RANGE_SEL 0.25 >> ! #define ANY_CHAR_SEL 0.9

[HACKERS] More pgindent follies

2001-05-20 Thread Tom Lane
As long as you're fixing bugs in pgindent, here are some more follies exhibited by the most recent pgindent run. Some of these bugs have been there for awhile, but at least one (the removal of space before a same-line comment) seems to be new as of the most recent run. The examples are all taken