Re: [HACKERS] More DROP COLUMN

2002-07-15 Thread Sergio A. Kessler
chris, have you looked at how sapdb (http://www.sapdb.org) does this ? /sergio ps: IANAL ""Christopher Kings-Lynne"" <[EMAIL PROTECTED]> escribió en el mensaje [EMAIL PROTECTED]">news:[EMAIL PROTECTED]... > OK, > > DROP COLUMN now seems to work perfectly. All the old test cases that failed >

Re: [HACKERS] More DROP COLUMN

2002-07-15 Thread Tom Lane
Hannu Krosing <[EMAIL PROTECTED]> writes: > or to make it even more self documenting store the drop time, > " col001 [EMAIL PROTECTED]" I'm not at all excited about trying to store times, random numbers, etc in dropped column names. We are not trying to do cryptography here, only invent an impro

Re: [HACKERS] More DROP COLUMN

2002-07-15 Thread Curt Sampson
On Mon, 15 Jul 2002, Zeugswetter Andreas SB SD wrote: > I would prefer a simple but highly predictable rule, where you can say > "Don't name your columns starting with " \353\010" (blank, greek d, > BS) over some random algo that stays out of the way by means of low > probability. \353 is not a

Re: [HACKERS] More DROP COLUMN

2002-07-15 Thread Hannu Krosing
On Mon, 2002-07-15 at 09:20, Christopher Kings-Lynne wrote: > > > etc. I put that extra number after dropped and not at the end > > so prevent it > > > being off the end of a 32 character name. > > > > > > > Alternatively, we could invest a lot of work to make it possible for > > > > attname to b

Re: [HACKERS] More DROP COLUMN

2002-07-15 Thread Zeugswetter Andreas SB SD
> However, I'm not happy with the way dropped columns are renamed. I want to > give them a name that no-one would ever want to use as a legit column name. > I don't like this behaviour: Yes, how about prepending a character that would usually need to be escaped. I like Hannu's proposal with th

Re: [HACKERS] More DROP COLUMN

2002-07-14 Thread Christopher Kings-Lynne
> > etc. I put that extra number after dropped and not at the end > so prevent it > > being off the end of a 32 character name. > > > > > Alternatively, we could invest a lot of work to make it possible for > > > attname to be NULL, but I don't see the payoff... > > > > Yeah, I think a weird name

Re: [HACKERS] More DROP COLUMN

2002-07-14 Thread Hannu Krosing
On Mon, 2002-07-15 at 06:06, Christopher Kings-Lynne wrote: > > > We could name the fields "dropped_x" sort of thing perhaps > > > > In practice that would certainly work, especially if we increase > > NAMEDATALEN to 128 or so, as has been proposed repeatedly. > > Well, x is just an i

Re: [HACKERS] More DROP COLUMN

2002-07-14 Thread Christopher Kings-Lynne
> > We could name the fields "dropped_x" sort of thing perhaps > > In practice that would certainly work, especially if we increase > NAMEDATALEN to 128 or so, as has been proposed repeatedly. Well, x is just an integer anyway, so even with 32 it's not a problem... In case anyone was

Re: [HACKERS] More DROP COLUMN

2002-07-14 Thread Curt Sampson
On Mon, 15 Jul 2002, Christopher Kings-Lynne wrote: > However, I'm not happy with the way dropped columns are renamed. I want to > give them a name that no-one would ever want to use as a legit column name. > ... > We could name the fields "dropped_x" sort of thing perhaps I suggest

Re: [HACKERS] More DROP COLUMN

2002-07-14 Thread Tom Lane
"Christopher Kings-Lynne" <[EMAIL PROTECTED]> writes: > However, I'm not happy with the way dropped columns are renamed. Okay... > We could name the fields "dropped_x" sort of thing perhaps In practice that would certainly work, especially if we increase NAMEDATALEN to 128 or so, as

[HACKERS] More DROP COLUMN

2002-07-14 Thread Christopher Kings-Lynne
OK, DROP COLUMN now seems to work perfectly. All the old test cases that failed now work fine. However, I'm not happy with the way dropped columns are renamed. I want to give them a name that no-one would ever want to use as a legit column name. I don't like this behaviour: test=# create tabl