Re: [HACKERS] Modify pg_stat_get_activity to build a tuplestore

2015-05-08 Thread Stephen Frost
* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > Stephen Frost wrote: > > > As I mentioned on another thread, you're certainly right about that, and > > here's the first broken-out patch, which just changes > > pg_stat_get_activity to build and return a tuplestore in a single > > function call

Re: [HACKERS] Modify pg_stat_get_activity to build a tuplestore

2015-05-08 Thread Alvaro Herrera
Stephen Frost wrote: > As I mentioned on another thread, you're certainly right about that, and > here's the first broken-out patch, which just changes > pg_stat_get_activity to build and return a tuplestore in a single > function call instead of using the old-style multiple-invokation call > meth

[HACKERS] Modify pg_stat_get_activity to build a tuplestore

2015-05-07 Thread Stephen Frost
All, * Robert Haas (robertmh...@gmail.com) wrote (on the role attributes * thread): > I think this patch is too big and does too many things. It should be > broken up into small patches which can be discussed and validated > independently. The fact that your commit message is incredibly long > i