Re: [HACKERS] Missing comment block at the top of streamutil.h and receivelog.h

2014-08-27 Thread Fujii Masao
On Wed, Aug 27, 2014 at 2:07 PM, Michael Paquier wrote: > On Wed, Aug 27, 2014 at 12:31 PM, Fujii Masao wrote: >> On Wed, Aug 27, 2014 at 10:34 AM, Michael Paquier >> wrote: >> I think that it's better to add an include guard like >> >> #ifndef RECEIVELOG_H >> #define RECEIVELOG_H >> ... >> #end

Re: [HACKERS] Missing comment block at the top of streamutil.h and receivelog.h

2014-08-26 Thread Michael Paquier
On Wed, Aug 27, 2014 at 12:31 PM, Fujii Masao wrote: > On Wed, Aug 27, 2014 at 10:34 AM, Michael Paquier > wrote: > I think that it's better to add an include guard like > > #ifndef RECEIVELOG_H > #define RECEIVELOG_H > ... > #endif Oh indeed, that was missing as well! Please see attached. -- Mi

Re: [HACKERS] Missing comment block at the top of streamutil.h and receivelog.h

2014-08-26 Thread Fujii Masao
On Wed, Aug 27, 2014 at 10:34 AM, Michael Paquier wrote: > On Wed, Aug 27, 2014 at 6:10 AM, Magnus Hagander wrote: >> On Tue, Aug 26, 2014 at 11:03 PM, Robert Haas wrote: >>> Probably that's a good idea, but do we really need Author: tags? I >>> know we have those in a few places, but certainly

Re: [HACKERS] Missing comment block at the top of streamutil.h and receivelog.h

2014-08-26 Thread Michael Paquier
On Wed, Aug 27, 2014 at 6:10 AM, Magnus Hagander wrote: > On Tue, Aug 26, 2014 at 11:03 PM, Robert Haas wrote: >> Probably that's a good idea, but do we really need Author: tags? I >> know we have those in a few places, but certainly not everywhere, and >> as time goes by they tend to be less ac

Re: [HACKERS] Missing comment block at the top of streamutil.h and receivelog.h

2014-08-26 Thread Magnus Hagander
On Tue, Aug 26, 2014 at 11:03 PM, Robert Haas wrote: > On Sat, Aug 23, 2014 at 11:59 PM, Michael Paquier > wrote: >> As mentioned in $subject, the header files in src/bin/pg_basebackup do >> not have a comment block at the top and do not have any copyright >> text. >> Any reason for that? Shouldn

Re: [HACKERS] Missing comment block at the top of streamutil.h and receivelog.h

2014-08-26 Thread Robert Haas
On Sat, Aug 23, 2014 at 11:59 PM, Michael Paquier wrote: > As mentioned in $subject, the header files in src/bin/pg_basebackup do > not have a comment block at the top and do not have any copyright > text. > Any reason for that? Shouldn't we have something for consistency with > the other files li

[HACKERS] Missing comment block at the top of streamutil.h and receivelog.h

2014-08-23 Thread Michael Paquier
Hi all, As mentioned in $subject, the header files in src/bin/pg_basebackup do not have a comment block at the top and do not have any copyright text. Any reason for that? Shouldn't we have something for consistency with the other files like in the patch attached? Regards, -- Michael diff --git