Re: [HACKERS] Missing checks on return value of timestamp2tm in datetime.c

2015-06-30 Thread Michael Paquier
On Tue, Jun 30, 2015 at 9:45 PM, Michael Paquier wrote: > timestamp2tm is called close to 40 times in the backend source code, > returning -1 in case of failure. However, there are two places in datetime.c > where we do not check for its return value: GetCurrentDateTime and > GetCurrentTimeUsec. >

[HACKERS] Missing checks on return value of timestamp2tm in datetime.c

2015-06-30 Thread Michael Paquier
Hi all, timestamp2tm is called close to 40 times in the backend source code, returning -1 in case of failure. However, there are two places in datetime.c where we do not check for its return value: GetCurrentDateTime and GetCurrentTimeUsec. This does not really matter much in practice as the times