On 2016/11/04 0:29, Robert Haas wrote:
Committed.
Thanks!
Tatsuro Yamada
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Tue, Oct 25, 2016 at 1:59 AM, Tatsuro Yamada
wrote:
> Hi Ashutosh,
>> You are right. Every call except that one is using NIL, so better to
>> fix it. The pattern was repeated in the recent aggregate pushdown
>> support. Here's patch to fix create_foreignscan_path() call in
>> add_foreign_groupi
Hi Ashutosh,
You are right. Every call except that one is using NIL, so better to
fix it. The pattern was repeated in the recent aggregate pushdown
support. Here's patch to fix create_foreignscan_path() call in
add_foreign_grouping_paths() as well.
Thanks for the review!
Tatsuro Yamada
NTT Op
On Mon, Oct 24, 2016 at 7:56 AM, Tatsuro Yamada
wrote:
> Hi,
>
> The last argument of create_foreignscan_path called by
> postgresGetForeignJoinPaths is
> set to NULL, but it would be suitable to set it to NIL because the argument
> type is List.
>
> Please find attached a patch.
>
You are right
Hi,
The last argument of create_foreignscan_path called by
postgresGetForeignJoinPaths is
set to NULL, but it would be suitable to set it to NIL because the argument
type is List.
Please find attached a patch.
Tatsuro Yamada
NTT Open Source Software Center
diff --git a/contrib/postgres_fdw/pos