Re: [HACKERS] LockDatabaseObject vs. LockSharedObject

2010-08-15 Thread Tom Lane
Robert Haas writes: > On Sun, Aug 15, 2010 at 3:22 PM, Tom Lane wrote: >> I'm not sure that we have any non-relation objects that are both complex >> enough and changeable enough for there to be an observable bug here, >> but it seems like a risk factor going forward.  It seems to me both safe >>

Re: [HACKERS] LockDatabaseObject vs. LockSharedObject

2010-08-15 Thread Robert Haas
On Sun, Aug 15, 2010 at 3:22 PM, Tom Lane wrote: > Robert Haas writes: >> It seems suspicious to me that LockSharedObject() calls >> AcceptInvalidationMessges() and LockDatabaseObject() does not.  Since >> the only caller of LockSharedObject() at present is >> AcquireDeletionLock(), I'm not sure

Re: [HACKERS] LockDatabaseObject vs. LockSharedObject

2010-08-15 Thread Tom Lane
Robert Haas writes: > It seems suspicious to me that LockSharedObject() calls > AcceptInvalidationMessges() and LockDatabaseObject() does not. Since > the only caller of LockSharedObject() at present is > AcquireDeletionLock(), I'm not sure there's an observable bug here at > the moment, but then

[HACKERS] LockDatabaseObject vs. LockSharedObject

2010-08-05 Thread Robert Haas
It seems suspicious to me that LockSharedObject() calls AcceptInvalidationMessges() and LockDatabaseObject() does not. Since the only caller of LockSharedObject() at present is AcquireDeletionLock(), I'm not sure there's an observable bug here at the moment, but then again, I'm also not sure there